Re: [xwiki-devs] [xwiki-notifications] r14298 - in platform/core/trunk: . xwiki-core xwiki-core/src/main/java/com/xpn/xwiki/render xwiki-core/src/main/java/com/xpn/xwiki/render/groovy xwiki-macros xwiki-macros/xwiki-macro-groovy xwiki-macros/xwiki-macro-groovy/src xwiki-macros/xwiki-macro-groovy/src/main xwiki-macros/xwiki-macro-groovy/src/main/resources xwiki-macros/xwiki-macro-groovy/src/main/resources/META-INF xwiki-macros/xwiki-macro-groovy/src/main/resources/META-INF/plexus xwiki-macros/xwiki-macro-groovy/src/test xwiki-macros/xwiki-macro-groovy/src/test/java xwiki-macros/xwiki-macro-groovy/src/test/java/org xwiki-macros/xwiki-macro-groovy/src/test/java/org/xwiki xwiki-macros/xwiki-macro-groovy/src/test/java/org/xwiki/rendering xwiki-macros/xwiki-macro-groovy/src/test/resources xwiki-macros/xwiki-macro-script xwiki-macros/xwiki-macro-script/src xwiki-macros/xwiki-macro-script/src/main xwiki-macros/xwiki-macro-script/src/main/java xwiki-macros/xwiki-macro-script/src/main/java/org xwiki-macros/xwiki-macro-script/src/main/java/org/xwiki xwiki-macros/xwiki-macro-script/src/main/java/org/xwiki/rendering xwiki-macros/xwiki-macro-script/src/main/java/org/xwiki/rendering/internal xwiki-macros/xwiki-macro-script/src/main/java/org/xwiki/rendering/internal/macro xwiki-macros/xwiki-macro-script/src/main/java/org/xwiki/rendering/internal/macro/script xwiki-macros/xwiki-macro-script/src/main/java/org/xwiki/rendering/macro xwiki-macros/xwiki-macro-script/src/main/java/org/xwiki/rendering/macro/script xwiki-macros/xwiki-macro-script/src/main/resources xwiki-macros/xwiki-macro-script/src/main/resources/META-INF xwiki-macros/xwiki-macro-script/src/main/resources/META-INF/plexus xwiki-macros/xwiki-macro-script/src/test xwiki-macros/xwiki-macro-script/src/test/java xwiki-macros/xwiki-macro-script/src/test/java/org xwiki-macros/xwiki-macro-script/src/test/java/org/xwiki xwiki-macros/xwiki-macro-script/src/test/java/org/xwiki/rendering xwiki-macros/xwiki-macro-script/src/test/java/org/xwiki/rendering/internal xwiki-macros/xwiki-macro-script/src/test/java/org/xwiki/rendering/internal/macro xwiki-macros/xwiki-macro-script/src/test/java/org/xwiki/rendering/scaffolding xwiki-macros/xwiki-macro-script/src/test/resources xwiki-macros/xwiki-macro-script/src/test/resources/macros xwiki-macros/xwiki-macro-script/src/test/resources/macros/script xwiki-macros/xwiki-macro-velocity xwiki-macros/xwiki-macro-velocity/src/main/java/org/xwiki/rendering/internal/macro/velocity xwiki-macros/xwiki-macro-velocity/src/main/resources/META-INF/plexus xwiki-rendering/src/main/java/org/xwiki/rendering/macro/descriptor xwiki-script xwiki-script/src xwiki-script/src/main xwiki-script/src/main/java xwiki-script/src/main/java/org xwiki-script/src/main/java/org/xwiki xwiki-script/src/main/java/org/xwiki/script xwiki-script/src/main/resources xwiki-script/src/main/resources/META-INF xwiki-script/src/main/resources/META-INF/plexus xwiki-script/src/test

[Sergiu Dumitriu]

tmortagne (SVN) wrote:
> Author: tmortagne
> Date: 2008-11-19 15:57:38 +0100 (Wed, 19 Nov 2008)
> New Revision: 14298

> Log:
> XWIKI-2825: Create a generic script macro

A quick review of the xwiki-script module:

- DefaultScriptContextManager and ScriptExecutionContextInitializer
should be in the internal package.
- ScriptExecutionContextInitializer is not declared in components.xml,
thus it is not used.
- getScriptContext calls the initializers on each call. Is that correct?
Shouldn't the context be initialized only once?
- scriptContextInitializerList (which also contains a typo in its name)
could be completely injected by Plexus, thus there's no need for
Initializable and Composable on this class. Just declare a dependency on
ScriptContextInitializer components.
- The javadocs on the interfaces could be improved... They are rather
short right now.
-- 
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs