On Mon, Dec 29, 2008 at 3:45 PM, Vincent Massol <[email protected]> wrote:
> > On Dec 29, 2008, at 3:28 PM, Guillaume Lerouge wrote: > > > On Mon, Dec 29, 2008 at 3:24 PM, Vincent Massol <[email protected]> > > wrote: > > > >> > >> On Dec 29, 2008, at 3:13 PM, Marius Dumitru Florea wrote: > >> > >>> Guillaume Lerouge wrote: > >>>> On Mon, Dec 29, 2008 at 2:57 PM, Vincent Massol > >>>> <[email protected]> wrote: > >>>> > >>>>> On Dec 29, 2008, at 2:29 PM, Guillaume Lerouge wrote: > >>>>> > >>>>>> On Mon, Dec 29, 2008 at 2:01 PM, Marius Dumitru Florea < > >>>>>> [email protected]> wrote: > >>> > >>> [snip] > >>> > >>>>>>> B) What should happen when you press Enter inside a header in > >>>>>>> the new > >>>>>>> WYSIWYG? > >>>>>>> > >>>>>>> B1) Currently, the text is moved on a new line, but still inside > >>>>>>> the > >>>>>>> header (multi-line header). > >>>>>>> > >>>>>>> I'm +1 since it's already done (We agreed that you have to press > >>>>>>> Enter > >>>>>>> twice to generate a new paragraph). > >>>>>> > >>>>>> +1 for this one since it's what we have and it's consistent with > >>>>>> the > >>>>>> "press > >>>>>> Enter twice" behavior. > >>>>> Can you explain why it's "consistent"? I don't understand the > >>>>> consistency. > >>>>> > >>>>> Imagine you're on a header. You've finished typing it and you > >>>>> press > >>>>> enter. You start typing your text to realize you're not in a > >>>>> paragraph. You select the text you've typed and click in the > >>>>> toolbar > >>>>> to select the paragraph style. Yuck! > >>> > >>> This is somehow true for paragraphs. A MS Word user would expect to > >>> write on a new paragraph after pressing enter. > >>> > >>>> > >>>> > >>>> I think you are making a confusion between 2 situations: > >>>> > >>>> 1) The caret is within the header : HEAD|ER > >>>> 2) The caret is at the end of the header : HEADER| > >>> > >>> What is the difference? If you want to write a multi-line header you > >>> write it on a single line and then split it in multiple lines? > >>> > >>> In this particular case I fill it's a yes or no decision regarding > >>> multi-line headers. If the answer is yes then Enter inside or at the > >>> end > >>> of a header should generate only a new line. > >> > > > > Ok. If we cannot separate both, I'm against multi-line headers as I > > think > > they do not make sense on the web > > Quite the opposite... :) > > HTML H elements support multilines so it's a web thing! The fact that it can be done doesn't mean it should be done ;-) Anyway that's not the main issue here. > > > > (since the skin prevents us from knowing > > the page width in advance the way it can be done in OpenOffice.org > > or MS > > Word). I'm afraid allwoing multi-line headers will trigger weird > > situations > > from the user PoW (A 2 lines header showing up on 3 lines on a small > > resolution display for instance) + it doesn't add much value on the > > web > > anyway. > > > > So here's my -0 for multi-lines headers (it would be a -1 if it wasn't > > already implemented). > > Check the other email from Thomas. > > > I'm not sure about this Marius. I don't think we absolutely want a 1 > >> to 1 mapping between wiki editor and wysiwyg editor. IMO the wysiwyg > >> editor is for easy entering of text and it should behave as you > >> expect > >> it to behave. > >> > >> Can someone contradict me in my thinking that almost everyone (i.e. > >> more than 90% of users) will think that after you hit enter at the > >> end > >> of a paragraph it'll go to next line using a para style? And if > >> that's > >> true I think we would be doing users a disservice by allowing > >> multiline headers by using the enter key. > > > > > > I agree with Vincent here: hitting enter at the end of a header > > should start > > a new paragraph. Thus if we cannot separate cases 1) and 2) we > > should not > > allow creating multi-lines headers in the WYSIWYG editor. > > I only said the first part, i.e that enter should create a para. We > could still allow new lines in headers using shift+enter for ex. Since > it's less well known key most users won't use it (and won't need it). I'm ok with this approach as well: - Hitting enter in or at the end of a header generates a new paragraph - Hitting shift + enter generates a multi-line header Guillaume > > > Thanks > -Vincent > > > Guillaume > > > > > >> > >> > >> Thanks > >> -Vincent > >> > >>>> In case 1) (which I believe is the one Marius was referring to), > >>>> pressing > >>>> enter once puts the header on 2 lines and pressing enter twice > >>>> creates a new > >>>> paragraph (consistent with what happens when pressing enter twice > >>>> after the > >>>> last item fo a list for instance). > >>>> > >>>> In case 2) (which is the one you are referring to), pressing enter > >>>> indeed > >>>> already creates a new paragraph. > >>>> > >>>> Is that correct Marius? > >>> > >>> Currently only 1) is implemented. > >>> > >>>> > >>>> Guillaume > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Guillaume Lerouge Product Manager - XWiki Skype ID : wikibc http://blog.xwiki.com/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
