On Jan 2, 2009, at 11:24 AM, Asiri Rathnayake wrote: > Hi Vincent, > > If you want to run your tests with different initial conditions you >> should use a Test Suite instead and pass the cleaner in the >> constructor of the Test Case class. >> >> That said, I don't see why you'd want to run the same tests again. >> Since the implementation is the same the result will be the same! >> What >> you need to test are the extra things you've added to >> WysiwygDefaultHTMLCleaner. >> > > WysiwygDefaultHTMLCleaner is used to clean html content coming from > wysiwyg > editor which has been copy-pasted by a user. Since such copy-pasted > html can > be coming from any office suit (or any html editor) we cannot use any > XXXOfficeHtmlCleaner for cleaning such html content. This is why we > have a > seperate html cleaner. > > But for the moment it is not complete, it's performing some basic > cleaning > which is a subset from OpenOfficeDefaultHTMLCleaner. Once we have > extra > cleaning added to WysiwygHTMLCleaner, we can write tests for those.
I was not commenting on whether we need WysiwygHTMLCleaner or not but on the tests which are not written correctly IMO. Thanks -Vincent http://xwiki.com http://massol.myxwiki.org http://xwiki.org _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
