Hi,

This is fine but it needs to be documented in the method with the
> parameter signature to explain why the params are not used.
>

In HTMLCleaner#clean(Reader, Map) method i have included a javadoc comment
which includes :

"@param cleaningParameters Additional parameters (implementation dependent)
for cleaning."

And in DefaultHTMLCleaner:

"/**
 * {...@inheritdoc}
 * <p>
 * {...@link DefaultHTMLCleaner} does not allow fine-tuning of html cleaning
via parameters.
 * </p>
 */"

I thought this was enough because of {...@inheritdoc} tag plus the additional
comment.

Sorry, may be I have misunderstood something.

Thanks.

- Asiri
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to