On Jan 8, 2009, at 5:24 PM, Asiri Rathnayake wrote:

> Hi Vincent,
>
> On Thu, Jan 8, 2009 at 5:48 PM, Vincent Massol <[email protected]>  
> wrote:
>
>> Hi,
>>
>> Some comments:
>>
>> * I don't think the Import space name is a good one for the office
>> importer. I'd rather not create a new space and move the 2 pages in
>> the XWiki space (my preference right now, otherwise users will be  
>> able
>> to edit the pages by default unless we provide a WebPreferences and  
>> it
>> makes securing the wiki harder) or use something like OfficeImporter
>> (less good IMO).
>
>
> +1 for moving to XWiki space. I didn't like it either.
>
>
>>
>> * Navigating to the Importer page shows error messages. I think that
>> page should not be shown and be hidden so that users don't navigate  
>> to
>> it. It could also be moved to the XWiki space for now.
>
>
> +1
>
>
>>
>> * We need a link from the top menu. It think that should be real  
>> quick
>> to add for 1.8M1
>
>
> +1
>
>
>>
>> * it's a little buggy right now but I have commented why in the jira
>> issue: http://jira.xwiki.org/jira/browse/XWIKI-3083
>
>
> * About the null pointer exception, yes it need to be fixed. But I  
> don't
> know why you get the same exception when you have started the OO  
> server.
> Anyway, it's probably something related to your setup (for which we  
> need an
> admin guide, I agree).

See the jira issue. It's because there's a bug with importing ODP  
files. It works fine if I import a DOC file.

> * About multiple saves, I think this is because of the  
> DocumentAccessBridge
> (not sure, need to check) or the wrong use of it. It's possible that  
> every
> time we invoke a set* method in DocumentAccessBridge for the same  
> document,
> a new document version gets created. But this is something I can  
> workaround.
> Will fix it asap.
>
> Thanks.
>
> - Asiri

Thanks
-Vincent
http://xwiki.com
http://xwiki.org
http://massol.net






_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to