Vincent Massol wrote: > On Jan 11, 2009, at 12:52 PM, Anca Paula Luca wrote: > >> Marius Dumitru Florea wrote: >>> Hi Vincent, >>> >>> vmassol (SVN) wrote: >>>> Author: vmassol >>>> Date: 2009-01-10 20:34:28 +0100 (Sat, 10 Jan 2009) >>>> New Revision: 15295 >>>> >>>> Modified: >>>> platform/web/trunk/wysiwyg/pom.xml >>>> Log: >>>> Removing what seems to be unneeded stuff... >>> On what basis?.. Both gwt-dev and gwt-dev-libs are needed, first >>> because >>> they contain the GWT compiler and second because they are required by >>> the hosted browser when running and debugging the WYSIWYG in hosted >>> mode. Then gwt-dev-libs needs to be unpacked. Have you tried to build >>> the WYSIWYG with a fresh m2 repo after this change? >> Fresh repo build passes, I deleted all the gwt-dev related entries >> in the repo >> and ran it. The hosted mode run will not work any longer since it >> needs some >> libraries unpacked from the zip (that is debug + tests, if we ran >> any). >> >> Since we don't do any hosted mode runs at build time, it's arguable >> if we need >> this setup in the pom in the default profile or not, but since debug >> is needed >> quite often and all debug related files and setups are committed, >> I'd say we >> keep this one too, and use maven magic to remove it from the default >> build. >
> +1 for having a profile for the debug mode. For me this is really low priority considering the issues I have in Jira. I'd like to revert the pom and leave the debug profile for when the editor is ready. > > -Vincent > >> Happy coding, >> Anca Luca >> >>> See >>> http://gwt-maven.googlecode.com/svn/docs/maven-googlewebtoolkit2-plugin/setup.html >>> >>> We have to revert. >>> >>>> Modified: platform/web/trunk/wysiwyg/pom.xml >>>> =================================================================== >>>> --- platform/web/trunk/wysiwyg/pom.xml 2009-01-10 18:53:52 UTC >>>> (rev 15294) >>>> +++ platform/web/trunk/wysiwyg/pom.xml 2009-01-10 19:34:28 UTC >>>> (rev 15295) >>>> @@ -8,7 +8,7 @@ >>>> <artifactId>xwiki-web-wysiwyg</artifactId> >>>> <name>XWiki Platform - Web - WYSIWYG</name> >>>> <packaging>war</packaging> >>>> - <description>XWiki's What You See Is What You Get editor</ >>>> description> >>>> + <description>XWiki's GWT WYSIWYG editor</description> >>>> <dependencies> >>>> <dependency> >>>> <groupId>com.google.gwt</groupId> >>>> @@ -27,21 +27,8 @@ >>>> <groupId>com.google.gwt</groupId> >>>> <artifactId>gwt-dev</artifactId> >>>> <version>${gwtVersion}</version> >>>> - <classifier>${platform}-libs</classifier> >>>> - <type>zip</type> >>>> - <scope>provided</scope> >>>> - </dependency> >>>> - <dependency> >>>> - <groupId>com.google.gwt</groupId> >>>> - <artifactId>gwt-dev</artifactId> >>>> - <version>${gwtVersion}</version> >>>> <classifier>${platform}</classifier> >>>> <scope>provided</scope> >>>> - <!-- We load this library this way because GWT looks for >>>> SWT libraries in the same folder --> >>>> - <!-- >>>> - <scope>system</scope> >>>> - <systemPath>${settings.localRepository}/com/google/gwt/ >>>> gwt-dev/${gwtVersion}/gwt-dev-${platform}.jar</systemPath> >>>> - --> >>>> </dependency> >>>> <dependency> >>>> <groupId>com.google.gwt</groupId> >>>> @@ -116,35 +103,8 @@ >>>> </dependencies> >>>> <build> >>>> <plugins> >>>> - <!-- Download and unpack the GWT libs --> >>>> <plugin> >>>> <groupId>org.apache.maven.plugins</groupId> >>>> - <artifactId>maven-dependency-plugin</artifactId> >>>> - <executions> >>>> - <execution> >>>> - <id>unzip-gwt-libs</id> >>>> - <phase>compile</phase> >>>> - <goals> >>>> - <goal>unpack</goal> >>>> - </goals> >>>> - <configuration> >>>> - <artifactItems> >>>> - <artifactItem> >>>> - <groupId>com.google.gwt</groupId> >>>> - <artifactId>gwt-dev</artifactId> >>>> - <version>${gwtVersion}</version> >>>> - <classifier>${platform}-libs</classifier> >>>> - <type>zip</type> >>>> - <overWrite>false</overWrite> >>>> - </artifactItem> >>>> - </artifactItems> >>>> - <outputDirectory>${settings.localRepository}/com/ >>>> google/gwt/gwt-dev/${gwtVersion}</outputDirectory> >>>> - </configuration> >>>> - </execution> >>>> - </executions> >>>> - </plugin> >>>> - <plugin> >>>> - <groupId>org.apache.maven.plugins</groupId> >>>> <artifactId>maven-compiler-plugin</artifactId> >>>> <executions> >>>> <execution> >>>> @@ -287,12 +247,6 @@ >>>> </properties> >>>> </profile> >>>> </profiles> >>>> - <repositories> >>>> - <repository> >>>> - <id>ibiblio</id> >>>> - <url>http://mirrors.ibiblio.org/pub/mirrors/maven2</url> >>>> - </repository> >>>> - </repositories> >>>> <pluginRepositories> >>>> <pluginRepository> >>>> <id>gwt-maven</id> > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
