On Fri, Mar 20, 2009 at 14:40, Thomas Mortagne <[email protected]> wrote: > On Fri, Mar 20, 2009 at 14:28, Marius Dumitru Florea > <[email protected]> wrote: >> Hi Dan, >> >> I think the general issue is that a macro is not able to "hide" some of >> its base macro parameters when it has fixed values for them. I don't >> know the details though. > > This could be fixed using some tag like @hide which is already needed > BTW since Box macro contains a field not usable from syntax/WYSIWYG. (not usable until we make a String -> List<Box> -> String bean converter which is not difficult to do anyway but would need http://jira.xwiki.org/jira/browse/XWIKI-3171 to be cleaner)
> >> >> Marius >> >> Dan Miron wrote: >>> Hi guys! I'd like to know what you think about this matter, which has >>> been raised on http://jira.xwiki.org/jira/browse/XWIKI-3375. >>> As I posted there, this is what I think: >>> >>> -the parameters for the two macros are completely different, so i see no >>> point for having the box specific parameters (cssClass, title, image, >>> width and blockTitle) among the rss macro's ones, this will lead to >>> confusion for the user. The box parameters are deduced from the rss >>> feed's properties and then passed to the box macro. No need for them to >>> be exposed in the Rss Macro. Therefore, extending the RssMacroParameters >>> from the BoxMacroParameters is unreliable. >>> >>> -extending the RssMacro from the AbstractBoxMacro<RssMacroParameters> >>> doesn't mean simply implementing AbstractBoxMacro.parseContent instead >>> of Macro.execute. Currently, most of the code about the box around the >>> css macro is placed in the box macro's implementation, which is >>> DefaultBoxMacro, so we do make use of the existing implementations. >>> Giving up using the box macro internally means giving up using most of >>> the features already presented in the box macro and rewriting them >>> >>> -and finally, the most time costing disadvantage is that extending the >>> rss macro from the box basically means rewriting this macro from >>> scratch, because it involves redesigning it, task that will cost us time. >>> >>> So, therefore, I'm -1 for this. >>> >>> Tnx, >>> Dan >>> _______________________________________________ >>> devs mailing list >>> [email protected] >>> http://lists.xwiki.org/mailman/listinfo/devs >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > > > > -- > Thomas Mortagne > -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
