On Mar 20, 2009, at 7:56 PM, Vincent Massol wrote: > > On Mar 20, 2009, at 6:54 PM, Sergiu Dumitriu wrote: > >> Vincent Massol wrote: >>> On Mar 20, 2009, at 5:54 PM, sdumitriu (SVN) wrote: >>> >>>> Author: sdumitriu >>>> Date: 2009-03-20 17:54:57 +0100 (Fri, 20 Mar 2009) >>>> New Revision: 17872 >>>> >>>> Modified: >>>> platform/core/trunk/xwiki-core/pom.xml >>>> Log: >>>> XWIKI-3405: Build fails if jfreechart from central is used >>>> Fixed. >>>> >>>> >>>> Modified: platform/core/trunk/xwiki-core/pom.xml >>>> =================================================================== >>>> --- platform/core/trunk/xwiki-core/pom.xml 2009-03-20 16:30:55 UTC >>>> (rev 17871) >>>> +++ platform/core/trunk/xwiki-core/pom.xml 2009-03-20 16:54:57 UTC >>>> (rev 17872) >>>> @@ -153,6 +153,16 @@ >>>> <groupId>xwiki.jfree</groupId> >>>> <artifactId>jfreechart</artifactId> >>>> <version>1.0.0-rc1</version> >>>> + <exclusions> >>>> + <exclusion> >>>> + <groupId>gnujaxp</groupId> >>>> + <artifactId>gnujaxp</artifactId> >>>> + </exclusion> >>>> + <exclusion> >>>> + <groupId>junit</groupId> >>>> + <artifactId>junit</artifactId> >>>> + </exclusion> >>>> + </exclusions> >>> >>> I don't understand why you've done this. If we can use jfreechart >>> from >>> central then we should remove the "xwiki" from the groupid. However >>> the reason we're not using the central version is because it has >>> removed an api we're using. See comments in the pom.xml: >> >> Yes, I know that. This is a "for the future, just in case" fix, >> meaning >> that we'll soon refactor the charting plugin, which might also >> eliminate >> the dependency on this call. And then we'll upgrade to a newer >> version, >> which also contains these dependencies (note the junit compile >> dependency which is bad), and this error will surface then. I don't >> know, this fix doesn't help anybody right now, but it also doesn't do >> any damage. > > ok I understand now.
Actually this should be removed since they've fixed their pom in version 1.0.1: http://repo2.maven.org/maven2/jfree/jfreechart/1.0.1/jfreechart-1.0.1.pom Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
