On Apr 2, 2009, at 1:30 PM, Jerome Velociter wrote: > Sergiu Dumitriu wrote: >> Lilianne E. Blaze wrote: >>> Hello, >>> Here's the newest version. >>> >>> Basically it bridges XWiki.sendMessage to MailSenderPlugin. >>> >>> It uses Reflection, so no circulars, but it's not exactly pretty. >>> >>> Why it's needed - registration / validation / activation e-mails are >>> still sent via obsolete Apache Commons SmtpClient, so they _do not_ >>> support SMTP AUTH. >>> >>> This is a _major_ problem because due to spam and other abuse less >>> and >>> less hosting providers / network admins allow SMTP without >>> authorization, and those who do are likely to have very insecure >>> infrastructure. >>> >>> I honestly believe this is a MUST HAVE for a secure, spam-free >>> configuration. >>> >>> Greetings, Lilianne >> >> Hi Lilianne, >> >> Thanks for this patch. I (and other developers) don't quite agree >> with >> its approach, but I guess we could include it for the moment, until >> we >> implement the mail component. It's a hack, but one not as bad as >> other >> hacks we have, and it does solve a problem. > > I agree. > > Since none of us has time right now to transform the mailsender in a > component, +1 to apply it to fix this until then.
-0 I don't agree with it but I won't block it because that code needs to be cleaned anyway. Note that if some other committers had done this code we would certainly have asked him to revert and fix the problem. Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
