Anca,

On Apr 2, 2009, at 2:39 PM, lucaa (SVN) wrote:

> Author: lucaa
> Date: 2009-04-02 14:39:27 +0200 (Thu, 02 Apr 2009)
> New Revision: 18196
>
> Modified:
>   platform/web/trunk/standard/src/main/webapp/templates/ 
> editwysiwygnew.vm
> Log:
> XWIKI-2501: Quote un wiki link breaks launching the wiki editor when  
> editing the new page
> * Fixed bug that prevented the GWT WYSIWYG editor to load for a page  
> with a single quote in the name
>
>
> Modified: platform/web/trunk/standard/src/main/webapp/templates/ 
> editwysiwygnew.vm
> ===================================================================
> --- platform/web/trunk/standard/src/main/webapp/templates/ 
> editwysiwygnew.vm     2009-04-02 01:29:20 UTC (rev 18195)
> +++ platform/web/trunk/standard/src/main/webapp/templates/ 
> editwysiwygnew.vm     2009-04-02 12:39:27 UTC (rev 18196)
> @@ -110,7 +110,7 @@
>       hookId: 'content',
>       inputURL: "${tdoc.getExternalURL("view",  
> $inputURLQueryString)}",
> #if($request.sync)
> -      syncPage: '$doc.fullName',
> +      syncPage: '${doc.fullName.replaceAll("'", "\\'")}',

Can you comment in the code why this is needed? Also why just  
apostrophe and not other chars?

>       plugins: 'separator text valign list indent undo format symbol  
> link image table macro importer sync',
>  #if($request.reset=="1")
>       syncReset: 1,
> @@ -120,8 +120,8 @@
> #end
>       syntax: "$doc.syntaxId",
>       toolbar: 'bold italic underline strikethrough | subscript  
> superscript | unorderedlist orderedlist | outdent indent | undo redo  
> | format | hr symbol | link unlink | importer | image | inserttable  
> deletetable | insertrowbefore insertrowafter deleterow |  
> insertcolbefore insertcolafter deletecol',
> -      space: '${doc.space}',
> -      page: '${doc.name}',
> +      space: '${doc.space.replaceAll("'", "\\'")}',
> +      page: '${doc.name.replaceAll("'", "\\'")}',

Same here.

Thanks
-Vincent

>
>       debug: #if($request.debug)'true'#else'false'#end
>     };
> //]]>
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to