Anca Paula Luca wrote: > Hi developers, > > I would like to refactor > > String getURL(String documentName, String action, String queryString, String > anchor) > > in the DocumentAccessBridge (whose documentName is actually used as a > document > fullName) to > > String getURL(DocumentName documentName, String action, String queryString, > String anchor) > > and implement multiwiki support for it, since now it uses XWiki.getURL() > which > uses current context wiki to generate the URL.
it does actually work for multiwiki, through XWikiDocument.setFullName() which parses the fullName as a full reference (wiki too), which we should probably also refactor to use the new DocumentNameFactory() for parsing. > > The calls to current function would be transformed in: > > DocumentNameFactory docNameFactory = ... > getURL(docNameFactory.createDocumentName(fullName), ...) > > which will have the same result as before. > > Since we will need to change all internal reference to documents in > DocumentNames instead of fullNames as Strings, this would be a step in this > direction, facilitated by the new DocumentNameSerializer and > DocumentNameFactory. > > Here's my +1 > WDYT? > > Thanks, > Anca Luca > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
