Hi Sergiu, On Apr 21, 2009, at 12:27 AM, sdumitriu (SVN) wrote:
> Author: sdumitriu > Date: 2009-04-21 00:27:36 +0200 (Tue, 21 Apr 2009) > New Revision: 18877 > > Modified: > platform/web/trunk/standard/pom.xml > platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/ > actionbuttons/actionButtons.js > Log: > [misc] Velocity code inside JS breaks the minimization process > > > Modified: platform/web/trunk/standard/pom.xml > =================================================================== > --- platform/web/trunk/standard/pom.xml 2009-04-20 21:32:42 UTC (rev > 18876) > +++ platform/web/trunk/standard/pom.xml 2009-04-20 22:27:36 UTC (rev > 18877) > @@ -139,6 +139,7 @@ > <artifactId>maven-dependency-plugin</artifactId> > <executions> > <execution> > + <id>unpack-dependencies</id> > <!-- Right phase is prepare-package, but it is only in > maven-2.1 > <phase>prepare-package</phase>--> > <phase>test</phase> > @@ -264,8 +265,9 @@ > </includes> > <!-- Exclude already minified files --> > <excludes> > - <exclude>**/*-min.js</exclude> > + <exclude>**/*-min.js</exclude> > <exclude>**/*-debug.js</exclude> > + <exclude>**/actionButtons.js</exclude> Would be great to have a comment here to explain why this is execluded maybe? (I wonder if we'll remember in a few months/year). Especially since the comment 'exclude already minified files"' doesn't match. Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
