Thomas Mortagne wrote:
> On Mon, Apr 27, 2009 at 16:52, Sergiu Dumitriu <[email protected]> wrote:
>> Thomas Mortagne wrote:
>>> On Mon, Apr 27, 2009 at 16:07, Sergiu Dumitriu <[email protected]> wrote:
>>>> Thomas Mortagne wrote:
>>>>> Hi dev,
>>>>>
>>>>> My use case is http://jira.xwiki.org/jira/browse/XWIKI-3418
>>>>>
>>>>> WDYT ?
>>>>>
>>>>> Here is my +1
>>>>>
>>>> Could you explain a bit? Current to what? Is it the document
>>>> corresponding to the request URL, and which stays the same during all
>>>> processing, or is it the "context document" that can be changed by
>>>> include calls?
>>> DocumentAccessBridge has only access to document from context (it
>>> could recalculate the document corresponding to the URL but this is
>>> difficult).
>>>
>>> Note that http://jira.xwiki.org/jira/browse/XWIKI-3418 is executed in
>>> the XHTML renderer after all the includes and so the context document
>>> is the rendered document and not the document where the link is.
>> Make sure to specify this in the Javadoc.
>>
>> What does it return? A DocumentName or a String? Should it instead
>> return the document itself?
> 
> It return a DocumentName (we are supposed to not use String anymore).
> Return the document itself is not needed we could add a
> getCurrentDocument latter if it's really needed.

OK, +1.
-- 
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to