Cristina Scheau wrote:
> Hi!
>
> Thank you very much for your code review.
>
> public interface IConstants {
>
>> Why do you need an interface for this?
>> This looks like a .net interface naming convention, but I did not see it
>> in the java world. The XWiki convention is documented here:
>> -
>>
>> http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle#HClass2FInterfacenames
>>
>
>
> I thought this kind of interface might be useful, because I will have a lot
> of constants ( the URL of every dialog box etc). Another reason for using
> this kind of interface is the localization. If you don't like it, I can
> remove it.
>
> Settings.java
>
>> I this a generic settings class or will it store just authentication
>> settings?
>>
>>
>
> I would like to store here all the settings, established by the user.I can
> make it more generic, using a dictionary structure which will have the keys
> the name of the properties and the value = the value itself.
>
Actually I think it should be less generic, meaning that IMO
authentication data should not be stored/retrieved with the other settings.
> XwikiAddIn.java
>
>> Can you explain a bit what is the role of this class? I hope this
>> doesn't become a massive singleton that will be used everywhere across
>> the sources.
>>
>>
>
>
> Yes, it is a singleton which stores the XMLRPC client and XWikiStructure. I
> promise that it won't become massive, but I think this two objects will be
> used in many classes and I would like to avoid sending them as parameters.
>
>
> I will add the proper documentation and change some class names.
> I've wrote also a post about what I've done to be more clear :
> http://gsoc.myxwiki.org/xwiki/bin/view/XWiki+Integration+With+Open+Office/Creating+a+wizard+for+connecting+to+an+XWiki+server
>
> Now I work on the navigation panel. I have a problem .. it is not clear for
> me how can I integrate the panel in the OpenOffice environment in order to
> look as a component of it (like the custom control from the XWord). Is
> anybody who knows? (I will ask today alsa the OOo API deveopers).
>
>
I digged a bit into this. OOo seems to have some mechanism for handling
[task] panes(panels) but they are only available in Impress and Draw
that use the drawing module.
- http://wiki.services.openoffice.org/wiki/Drawing_framework
-
http://api.openoffice.org/docs/common/ref/com/sun/star/drawing/framework/XPaneFactory.html
-
http://api.openoffice.org/docs/common/ref/com/sun/star/drawing/framework/XPaneController.html
-
http://api.openoffice.org/docs/common/ref/com/sun/star/drawing/framework/XPane.html
I don't know if this is available in Writer or if it allows you to
create your own custom panes.
You should ask more on the OOo lists.
> Let me know if there are any other changes that I should do at the written
> classes.
>
> Best regards,
> Cristina
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
>
>
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
