+1, JV.
On Tue, Jun 2, 2009 at 2:54 PM, Marius Dumitru Florea <[email protected]> wrote: > Hi devs, > > Currently our Checkstyle configuration contains this: > > <module name="LineLength"> > <property name="ignorePattern" value="(@version|@see|@link|^import)"/> > <property name="max" value="120"/> > </module> > > I propose we add the following pattern to the ignorePattern property: > > @(\w+\.)+\w+::\w+\( > > The reason is that "Java identifiers referenced from within JSNI methods > can get quite long and cannot be parsed if split across lines." ( > http://code.google.com/webtoolkit/makinggwtbetter.html#codestyle ). > > Here's an example: > > var editor = > @com.xpn.xwiki.wysiwyg.client.editor.WysiwygEditorApi::new(Lorg/xwiki/gwt/dom/client/JavaScriptObject;)(config); > [email protected]::getSourceText(Lorg/xwiki/gwt/dom/client/JavaScriptObject;Lorg/xwiki/gwt/dom/client/JavaScriptObject;)(onSuccess, > onFailure); > > So without modifying the ignorePattern I'm forced to exclude an entire > Java source file from Checkstyle just because some of the JSNI lines are > too long. > > I'm +1 changing the ignorePattern property. > > Thanks, > Marius > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
