Hi,

> >
> > Actually it does not handle space yet as far as i can see in the code
> > but it should.
>
> So why aren't we using that one for setting the parent?
>
> Actually, why aren't we using _any serializer_ for the parent?
>
>     public void setParent(DocumentName parentName)
>     {
>         this.parent = parentName.toString();
>     }
>
> DocumentName
>
>     @Override
>     public String toString()
>     {
>         return getWiki() + ":" + getSpace() + "." + getPage();
>     }
>
> Is there some reason for this or we just forgot about it?


I think we forgot about it.

I will fix the set parent method. I don't think it's correct to use a
serializer inside the toString() method because well.... it's the toString()
method. Instead we should use a serializer inside the setParent() method.

Thanks.

- Asiri
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to