On Jun 29, 2009, at 11:21 AM, asiri (SVN) wrote:
> Author: asiri
> Date: 2009-06-29 11:21:59 +0200 (Mon, 29 Jun 2009)
> New Revision: 21683
>
> Modified:
> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-
> rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/chart/
> TestChartMacro.java
> Log:
> [misc] Moving the temporary chart image file generated during tests
> inside the target directory.
>
> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/
> xwiki-rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/
> chart/TestChartMacro.java
> ===================================================================
> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-
> rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/chart/
> TestChartMacro.java 2009-06-29 09:01:23 UTC (rev 21682)
> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-
> rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/chart/
> TestChartMacro.java 2009-06-29 09:21:59 UTC (rev 21683)
> @@ -38,6 +38,6 @@
> */
> protected File getChartImageFile(ChartMacroParameters
> parameters, String content)
> {
> - return new File("./chart.png");
> + return new File("./target/chart.png");
This is very bad. You should never hardcode maven directories location.
Thanks
-Vincent
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
