Sergiu Dumitriu wrote: > Vincent Massol wrote: >> Hi Thomas, >> >> On Jul 13, 2009, at 3:20 PM, tmortagne (SVN) wrote: >> >>> Author: tmortagne >>> Date: 2009-07-13 15:20:03 +0200 (Mon, 13 Jul 2009) >>> New Revision: 21910 >>> >> General comments: >> - Would be great if you could separate code reformatting from code >> changes. It makes it hard to read (I didn't read the commit fully as a >> consequence). > > +10 > >> - The code style has broken my styles in lots of places (see below for >> some comments, I haven't commented every single place it broke >> voluntary formatting). >> >> I'd like to vote for not applying code style blindly in the future. It >> breaks styles in lots of places and I hate it when I spend a good >> amount of my time to align code properly and it breaks it for >> producing suboptimal styling... > > There are two things to balance here: > - forgetting to format the code manually > - suboptimal formatting done automatically > > I for one prefer to have more codestyle-compliant code than less, and > automatic application does this.
I agree with Sergiu here, maybe, if automatic is suboptimal, we need to revisit our codestyle files. It's quite difficult to only format pieces of a file (one's changes), and it often results in forgetting to do it. Happy coding, Anca > > The way I do commits is: > > - change the code > - check what would the commit look like (using git diff) > - if I detect something wrong in the codestyle, I selectively accept > changes in the commit, using git add --interactive, which allows me to > choose which files to commit, and even inside a file, which changes > - final check on the prepared commit using git diff --cached > > This process takes a while, but it ensures high quality commits. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
