Hi Anca, On Wed, Oct 7, 2009 at 3:41 PM, Anca Paula Luca <ancapaula.l...@xwiki.com>wrote:
> On 10/07/2009 12:52 PM, Asiri Rathnayake wrote: > > Hi Devs, > > > > Currently the method signature looks like: > > > > public String officeToXHTML(String pageName, Map<String, String> > > cleaningParams) throws XWikiGWTException > > > > The contract is that this method will import whatever the "latest" > > attachment to the given document into xhtml. This is bit unsafe and we > have > > a better option of using com.xpn.xwiki.wysiwyg.client.util.Attachment > > instead. > > And a workaround to get the correct name of the uploaded file (since it's > not > the same as the file on disk, because of cleanup). > Yes, I plan to use AbstractFileUploadWizardStep which internally uses WysiwygService::getAttachment(String wikiName, String spaceName, String pageName, String attachmentName):Attachment; method which you have added ;) Thanks. - Asiri > > +1 > > Happy hacking, > Anca > > > > > So the new method that would be introduced is: > > > > public String officeToXHTML(Attachment attachment, Map<String, String> > > cleaningParams) throws XWikiGWTException; > > > > This is more clean, expressive and safe. > > > > WDYT? > > > > - Asiri > > _______________________________________________ > > devs mailing list > > devs@xwiki.org > > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ > devs mailing list > devs@xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
