Is there a space where the clean colibri skin is set on incubator ? Thanks, JV.
On Fri, Oct 16, 2009 at 6:39 PM, Ecaterina Valica <[email protected]> wrote: > Hi devs, > > One of the items for the 2.1 XE is: > "Clean the colibri skin so that it's no longer a pile of code added on top > of Toucan" > > I would ask you to help me test the cleanup for the Colibri skin. The > cleanup was made on the XE 2.0 release. > > You can find colibri.css, ie-6.css and ie-all.css at: > http://incubator.myxwiki.org/xwiki/bin/download/Skins/ColibriClean/colibri.css > http://incubator.myxwiki.org/xwiki/bin/download/Skins/ColibriClean/ie-6.css > http://incubator.myxwiki.org/xwiki/bin/download/Skins/ColibriClean/ie-all.css > > From the original colibri.css size of 73,9 Ko and 4408 lines of code, > now we have 29,7 Ko and 1526 lines of code. > > My problem is that I didn't delete too much. You can find the leftovers at: > http://incubator.myxwiki.org/xwiki/bin/download/Skins/ColibriClean/colibriLeftovers.css > > The code could be even more compressed if there weren't so many > inconsistencies in the markup for doing the same thing (ex. button usage, > panel input elements, etc). > > I didn't use anything from the colibri/ie.css - so this can be deleted if > the cleanup is accepted and committed. > > There are some standards in the cleanup, like: > - alphabetical order for the css proprieties; > - 2 spaces indentation for the proprieties; > - comment headers for separation and grouping of different parts of the > code; > - "Overwrites" and "Should be in" comments for dependencies overwriting. > > It would be nice if the code can be tested in a more "advanced" manner to > cover for the unusual parts that I might not cover in my testing. > There are some minor differences from the XE2.0 Colibri in the display. My > request is: if you find one of those be sure it doesn't have another style > associated or the problem is not in the CSS, but in the markup. > > You can report bugs replying to this mail or on the incubator page > http://incubator.myxwiki.org/xwiki/bin/view/Skins/ColibriClean > > Thank you, > Caty > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
