On Oct 19, 2009, at 4:33 AM, Asiri Rathnayake wrote: > Hi Vincent, > > On Sun, Oct 18, 2009 at 12:28 PM, Vincent Massol > <[email protected]> wrote: > >> Hi Asiri, >> >> I see there's 10% of code duplication in the webdav module: >> http://nemo.sonarsource.org/project/index/181898 >> >> This is the highest of all modules. Do you think you could have a >> look? >> > > I'd be glad to :) > > WebDAV module is still dependant on xwiki-core, I was waiting for a > chance > to refactor it. Although, I suspect that this could take some effort. > > Do you want me to: > > 1) Just fix duplications & improve the code. > > 2) Refactor the module to get rid of xwiki-core dependancy as well. > > I will start with 1).
For me this is an ongoing process to improve/refactor/clean up existing code. It's not something we should do 100% of our time but more as a background thread with a low priority but that runs all the time. 1) and 2) are fine but don't stop everything you're doing to do them (it should not endanger anything you're working on). Instead work on them small steps at a time. Thanks -Vincent > > Thanks. > > - Asiri > > >> >> Second worst is REST with 5% >> http://nemo.sonarsource.org/components/index/178319 >> >> In term of technical debt, WebDAV module is also high with 9.5% and >> the highest is the XMLRPC module with 12.2%. >> >> Thanks >> -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
