On Wed, Oct 21, 2009 at 08:41, Vincent Massol <[email protected]> wrote:
>
> On Oct 21, 2009, at 8:30 AM, Thomas Mortagne wrote:
>
>> On Mon, Oct 19, 2009 at 12:38, Vincent Massol <[email protected]>
>> wrote:
>>>
>>> On Oct 19, 2009, at 12:26 PM, Thomas Mortagne wrote:
>>>
>>>> On Sun, Oct 18, 2009 at 14:00, vmassol <[email protected]
>>>>> wrote:
>>>>> Author: vmassol
>>>>> Date: 2009-10-18 14:00:31 +0200 (Sun, 18 Oct 2009)
>>>>> New Revision: 24550
>>>>>
>>>>> Modified:
>>>>> platform/core/trunk/xwiki-xml/pom.xml
>>>>> Log:
>>>>> Fixed invalid dependencies. At test time the Embedded CM needs to
>>>>> be available...
>>>>
>>>> This is already provided by shared-test, it's needed at this level
>>>> only if the test directly use it.
>>>
>>> Shared-test provide it as a non test dep AFAICS.
>>>
>>> FYI I've fixed these deps since m2eclipse was failing to build the
>>> modules without them.
>>
>> It works well with last stable m2eclipse (0.9.8), does not seems right
>> to put hacks in pom.xml for m2eclipse bug.
>
> I don't think it's a m2eclipse bug. m2eclipse uses Maven 3 directly.
> My guess is that if you try it with maven 3 you'll get the same
> problem. My take is that Maven 2 was more permissive and worked for
> some reason I cannot understand yet.
>
> I haven't looked at it in a lot of details but if you have can you
> explain why this dependency wouldn't be needed? (especially as I don't
> see it provided by shared test and it's needed in the tests of xwiki-
> xml).
>
> Maybe shared-test get it transitively but in this case it isn't
> correct IMO to depend on some other deps to provide it.
I just looked and yes shared-test get it from one of its dependencies
which is wrong and should be fixed but still component manager
implementation is shared-test choice since its initializing it.
I'm fixing shared-test now but IMO it's a maven 3 or m2eclipse bug as
you want, core-xml does not use component-default, shared-test does.
>
> Thanks
> -Vincent
>
>>>>> Modified: platform/core/trunk/xwiki-xml/pom.xml
>>>>> ===================================================================
>>>>> --- platform/core/trunk/xwiki-xml/pom.xml 2009-10-18 11:59:59
>>>>> UTC (rev 24549)
>>>>> +++ platform/core/trunk/xwiki-xml/pom.xml 2009-10-18 12:00:31
>>>>> UTC (rev 24550)
>>>>> @@ -68,6 +68,12 @@
>>>>> <version>${pom.version}</version>
>>>>> <scope>test</scope>
>>>>> </dependency>
>>>>> + <dependency>
>>>>> + <groupId>org.xwiki.platform</groupId>
>>>>> + <artifactId>xwiki-core-component-default</artifactId>
>>>>> + <version>${pom.version}</version>
>>>>> + <scope>test</scope>
>>>>> + </dependency>
>>>>> </dependencies>
>>>>> <build>
>>>>> <plugins>
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
>
--
Thomas Mortagne
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
