Hi Vincent,

Vincent Massol wrote:
> Hi,
> 
> The XWiki project is now fully set up on Nemo here:
> http://nemo.sonarsource.org/components/index/XWIKI

Nice!

> 
> Comments:
> * Since our junit test no longer fail with memory issue they've added  
> back test coverage stats. Link to platform: 
> http://nemo.sonarsource.org/project/index/178319

I wish WYSIWYG unit tests were run, but they need a 32-bit JVM which is 
hard to enforce in the pom.

> * They've just added the "Commented LOC" stat feature which shows the  
> number of lines of commented code. We shouldn't have any commented out  
> code so we'll need to gradually reduce this too.

Unfortunately they consider native methods like this:

// GWT Java code
native Node getNextSibling()
/*-{
     // JavaScript code
     return this.nextSibling;
}-*/;

to have commented out code.. This applies only for GWT code though.

Thanks,
Marius

> * The test coverage don't count integration and functional tests, i.e.  
> if a unit tests tests code from another module the coverage is not  
> taken into account. Thus all our rendering tests in xwiki-rendering- 
> tests are not taken into account (they cover 90% of the rendering api  
> code...).
> * Since they've added the unit tests the tech debt has gone down a  
> lot. I'll ask them why.
> 
> Thanks
> -Vincent
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to