On Tue, Nov 10, 2009 at 18:20, Anca Luca <[email protected]> wrote: > Hi devs, > > I'm reviving this thread since I didn't really get any votes, and I'm about to > pick some development direction. > > On 10/30/2009 05:21 PM, Anca Luca wrote: >> Hi devs, >> >> following a discussion with Fabio about the second desired feature for the >> annotations, namely the ability to add annotations on any document, no matter >> how its content is generated, we came up with the solution described at >> http://dev.xwiki.org/xwiki/bin/view/Design/AnnotationFeature#HSolution1storeannotationsasselectionandcontextovertransformeddocuments >> , the main idea being that annotations would be defined by their selected >> text >> and a context (as opposed to offsets) and would be identified to be rendered >> in >> a document on a serialization of the transformed XDOM of the document, this >> way >> taking into account any macro rendering, document inclusion, etc. >> >> WDYT about this solution? > > Is there anything you see not doable in this? or any of its "cons" is a > showstopper?
Sounds good, i don't see any important issue for now. > >> >> Also, because the implementation of this, though relatively localized, comes >> together with refactor and cleanup of the annotations module (update >> everything >> so that annotations don't store and use offsets anymore, remove classes& >> functions which are not needed in this simplified process), I propose to >> include >> this improvement in version 1.0 of the annotations module (so that we don't >> cleanup and release what we know for sure we'll delete) and push the 1.0 >> version >> further to mid to end December. >> >> here's my +1 for this, >> WDYT? > > Following a discussion with Fabio today, the plan at this moment is to: > 1/ finish improving the tests (so that the power and limitations of the > current > solution are checked by a set of tests) > 2/ eliminate all the code related to implementations for specific document > types > (watch's feed entry documents, for example, everything should be handled as an > xwiki doc), so that the remaining code is cleaner and easier to maintain > 3/ implement a prototype of the solution presented above, hopefully passing at > least the tests that were passing at 1/ > 4/ minimal improvements on the js UI, making it usable in real life > 5/ release 1.0 > > Is there a different strategy you would prefer? > > Thanks, > Anca > >> >> >> Happy coding, >> Anca >> >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
