Vincent Massol wrote: > On Nov 18, 2009, at 8:46 AM, Marius Dumitru Florea wrote: > >> Hi Vincent, >> >> Vincent Massol wrote: >>> On Nov 18, 2009, at 12:44 AM, mflorea (SVN) wrote: >>> >>>> Author: mflorea >>>> Date: 2009-11-18 00:44:21 +0100 (Wed, 18 Nov 2009) >>>> New Revision: 25111 >>>> >>>> Modified: >>>> platform/web/branches/xwiki-web-2.0/wysiwyg/src/main/resources/com/ >>>> xpn/xwiki/wysiwyg/client/editor/Strings.properties >>>> Log: >>>> XWIKI-4581: Change the name for "Background Color" to "Highlight >>>> Color" >>>> >>>> Merged from trunk, revision 25110. >>>> >>>> >>>> Modified: platform/web/branches/xwiki-web-2.0/wysiwyg/src/main/ >>>> resources/com/xpn/xwiki/wysiwyg/client/editor/Strings.properties >>>> =================================================================== >>>> --- platform/web/branches/xwiki-web-2.0/wysiwyg/src/main/resources/ >>>> com/xpn/xwiki/wysiwyg/client/editor/Strings.properties 2009-11-17 >>>> 23:43:13 UTC (rev 25110) >>>> +++ platform/web/branches/xwiki-web-2.0/wysiwyg/src/main/resources/ >>>> com/xpn/xwiki/wysiwyg/client/editor/Strings.properties 2009-11-17 >>>> 23:44:21 UTC (rev 25111) >>>> @@ -5,7 +5,7 @@ >>>> apply=Apply >>>> select=Select >>>> attachment=Insert an Attachment Link >>>> -backColor=Background Color >>>> +backColor=Highlight Color >>> Minor: >>> >>> Is it the background color or the highlight color? >> It is highlight color. Both Open Office Writer and Microsoft Word use >> this term to define the action of changing the background color of the >> selected text. > > If they're doing it they must be right I guess.... I would never has > imagined that highlight color would be about the background color... > >> Open Office has in fact both: background color affects >> the entire line not just the selected text as it happens with >> highlight >> color; and you can apply both at the same time: highlight color has >> priority. >> >>> If highlight is the correct one then maybe the key name should be >>> changed too? At the very least I think a comment would be necessary >>> since someone reading this line will not know who's right... the key >>> or the value... Highlight is a term that refers to me as a foreground >>> color. >> IMO background color is more generic (or vague) than highlight color > > Background is definitely way more precise than highlight to me. > Highlight means to... highlight. There are lots of ways to highlight > something: you could underline it (so it could the underline color), > it could be the text color (this is what is used daily by everyone > when they write on paper and want to highlight some word), you could > draw a square around the text, and apparently in OO's case it's about > changing the background color... >
> Anyway if they do it.... let's hope they thought this out and I'm the > only one who dislike "highlight color" :) I'm not a big fan myself but apparently, as Silvia pointed out, this term is well understood among those using rich text editors. Now I see that CKEditor is still using "Background color". Guillaume, WDYT? Marius > > Thanks for the explanation > -Vincent > >> so >> I don't think there is a contradiction between these terms (although >> for >> Open Office they have different meanings). That's why I didn't change >> the key. I could do it but then I guess I should also update the >> class, >> method, field or variable names to reflect this changed, which is a >> pain. Also, the feature is call backcolor so I should change it too >> and >> then the documentation. The reason for the tooltip change was just to >> make it more specific. >> >> Thanks, >> Marius >> >>> Thanks >>> -Vincent >>> _______________________________________________ >>> devs mailing list >>> [email protected] >>> http://lists.xwiki.org/mailman/listinfo/devs >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
