Hi, On 11/20/2009 12:04 AM, Sergiu Dumitriu wrote: > On 11/19/2009 06:11 PM, Marius Dumitru Florea wrote: > >> Hi devs, >> >> I'd like to move >> http://svn.xwiki.org/svnroot/xwiki/platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/server/filter/XWikiContextInitializationFilter.java >> to >> http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ >> >> Here's my +1. >> +1 > - Will it only be used by the gwtrpc servlet? > No, IMO it is recommended that all servlets use it. > - If not, do you plan to rework the code in XWikiAction that does mostly > the same thing? > Probably not. The code is redundant in several places and will be replaced in time. Marius did the gwtrpc implemetation, I'll do the xmlrpc cleanup. > - Why is the context mode configured in the filter? > The mode is set in the filter to replace the behavior inside Utils.prepareXWikiContext. Currently the mode is set by checking the type of the request. Eg: the only purpose of the class XmlRpcRequest is to provide a different type for the instance of the XWikiRequest while in prepareContext. This is not nice, and impossible to use with filters, as a custom instantiation cannot be done before the filter. Using filter parameters and servlet mapping seems more elegant, thus setting the mode in the filter. > Thanks,
Florin Ciubotaru _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
