On 11/25/2009 11:56 AM, Guillaume Lerouge wrote: > Hi, > > On Wed, Nov 25, 2009 at 11:35 AM, Sergiu Dumitriu<[email protected]> wrote: > >> On 11/25/2009 11:31 AM, Vincent Massol wrote: >>> Hi committers, >>> >>> I'd like to propose a new committer on XWiki core: Caleb. >>> >>> - Caleb has been regularly posting good patches in JIRA. >>> - He's also been courageous enough to tackle complex issues (changing >>> core stuff is always complex ;)). >>> - Even though Caleb has been active only since August 2009, the >>> quality of his work justifies that we make him a committer. >>> - Caleb has the right attitude: asking on the list, respectful >>> >>> Some stats: >>> >>> - Mails sent by Caleb (36): >>> http://xwiki.markmail.org/search/?q=from%3ACaleb >>> >>> - Patches from Caleb that have been applied (5): >>> http://xwiki.markmail.org/search/?q=%22Patch+from+Caleb%22 >>> >>> - Total patches from Caleb (9): >>> http://xwiki.markmail.org/search/?q=calebjamesdelisle+keywords+patch >>> >>> - Mails mentioning Caleb (114): >>> http://xwiki.markmail.org/search/?q=Caleb >>> >>> - Patches not applied yet (4): >>> - http://jira.xwiki.org/jira/browse/XWIKI-4367 >>> - http://jira.xwiki.org/jira/browse/XWIKI-4287 >>> - http://jira.xwiki.org/jira/browse/XWIKI-1716 >>> - http://jira.xwiki.org/jira/browse/XWIKI-3355 >>> - http://jira.xwiki.org/jira/browse/XSKINX-9 >>> - http://jira.xwiki.org/jira/browse/XWIKI-4326 >>> >>> In addition I know Caleb will not commit something he's not sure about. >>> >>> I'm +1 to make Caleb a committer. >>> >>> Committers, please vote. >> >> +1, but he'll still need commit reviews for the following months. >> > > Do you imply that some people don't need commit reviews? ;-)
I trust Marius. Of course everybody would benefit from code reviews, I was just saying that we must pay more attention in the beginning. -- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
