The fact that it uses translations with the panels.* prefix is wrong, we need to use a core.search.* (or platform.search.* ?) prefix for the text in the header. About the label itself having a voice reader reading "search query" to describe the input is better than "search", WDYT ? Any other opinions about this ?
I'll commit the fixes when we'll find an agreement. Thanks, JV. On Thu, Dec 17, 2009 at 11:39 AM, Ecaterina Valica <[email protected]> wrote: > The Search label in the global.vm uses panels.search.inputLabel > > <label class="hidden" > for="headerglobalsearchinput">$msg.get('panels.search.inputLabel')</label> > > > On Thu, Dec 17, 2009 at 12:08, jvdrean <[email protected]> > wrote: >> >> Author: jvdrean >> Date: 2009-12-17 11:08:18 +0100 (Thu, 17 Dec 2009) >> New Revision: 25832 >> >> Modified: >> >> platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties >> >> platform/xwiki-applications/trunk/panels/src/main/resources/Panels/Search.xml >> Log: >> XAPANELS-106 : Missing label for search input field in Panels.Search >> >> + removed tag object >> >> Modified: >> platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties >> =================================================================== >> --- >> platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties >> 2009-12-17 09:58:26 UTC (rev 25831) >> +++ >> platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties >> 2009-12-17 10:08:18 UTC (rev 25832) >> @@ -919,6 +919,7 @@ >> panels.translation.existingTranslations=Existing translations: >> >> panels.search.title=Search >> +panels.search.query=Search query >> panels.search.inputLabel=Search >> panels.search.inputText=search... >> panels.search.submit=Go >> >> Modified: >> platform/xwiki-applications/trunk/panels/src/main/resources/Panels/Search.xml >> =================================================================== >> --- >> platform/xwiki-applications/trunk/panels/src/main/resources/Panels/Search.xml >> 2009-12-17 09:58:26 UTC (rev 25831) >> +++ >> platform/xwiki-applications/trunk/panels/src/main/resources/Panels/Search.xml >> 2009-12-17 10:08:18 UTC (rev 25832) >> @@ -22,39 +22,6 @@ >> <comment></comment> >> <object> >> <class> >> -<name>XWiki.TagClass</name> >> -<customClass></customClass> >> -<customMapping></customMapping> >> -<defaultViewSheet></defaultViewSheet> >> -<defaultEditSheet></defaultEditSheet> >> -<defaultWeb></defaultWeb> >> -<nameField></nameField> >> -<validationScript></validationScript> >> -<tags> >> -<name>tags</name> >> -<prettyName>Tags</prettyName> >> -<unmodifiable>0</unmodifiable> >> -<relationalStorage>1</relationalStorage> >> -<displayType>input</displayType> >> -<multiSelect>1</multiSelect> >> -<size>30</size> >> -<separator> </separator> >> -<cache>0</cache> >> -<separators> ,|</separators> >> -<values></values> >> -<number>1</number> >> -<classType>com.xpn.xwiki.objects.classes.StaticListClass</classType> >> -</tags> >> -</class> >> -<name>Panels.Search</name> >> -<number>0</number> >> -<className>XWiki.TagClass</className> >> -<property> >> -<tags/> >> -</property> >> -</object> >> -<object> >> -<class> >> <name>Panels.PanelClass</name> >> <customClass></customClass> >> <customMapping></customMapping> >> @@ -138,7 +105,8 @@ >> <content>#panelhiddenheader($msg.get("panels.search.title")) >> <form action="$xwiki.getURL('Main.WebSearch')"> >> <div class="globalsearch"> >> - <input class="globalsearchinput" type="text" name="text" >> value="$msg.get('panels.search.inputText')" size="15" onfocus="if >> (this.value == '$msg.get('panels.search.inputText')') value=''; >> this.select();" onblur="if (this.value == '') >> value='$msg.get('panels.search.inputText')'; this.blur()"/> >> + <label for="globalsearchinput" >> class="hidden">$msg.get('panels.search.query')</label> >> + <input id="globalsearchinput" class="globalsearchinput" >> type="text" name="text" value="$msg.get('panels.search.inputText')" >> size="15" onfocus="if (this.value == '$msg.get('panels.search.inputText')') >> value=''; this.select();" onblur="if (this.value == '') >> value='$msg.get('panels.search.inputText')'; this.blur()"/> >> &nbsp; >> <input class="button" value="$msg.get('panels.search.submit')" >> type="image" src="$xwiki.getSkinFile('go.png')" >> alt="$msg.get('panels.search.submit')"/> >> </div> >> >> _______________________________________________ >> notifications mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/notifications > > > _______________________________________________ > notifications mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/notifications > > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
