Hi, On Thu, Dec 31, 2009 at 4:54 PM, Sergiu Dumitriu <[email protected]> wrote:
> On 12/31/2009 08:39 AM, asiri (SVN) wrote: > > Author: asiri > > Date: 2009-12-31 08:39:16 +0100 (Thu, 31 Dec 2009) > > New Revision: 25984 > > > > Modified: > > contrib/sandbox/xwiki-officepreview/pom.xml > > > contrib/sandbox/xwiki-officepreview/src/main/java/org/xwiki/officepreview/OfficePreviewVelocityBridge.java > > > contrib/sandbox/xwiki-officepreview/src/main/java/org/xwiki/officepreview/internal/OfficePreviewVelocityContextInitializer.java > > Log: > > [misc] Changing all platform dependencies to 2.1-SNAPSHOT version. > > > > * This will make it possible to use xwiki-officepreview with XE 2.1.x > versions. > > > > * Downside is that xwiki-officepreview will not be able to preview Office > 2007 documents (support for which was added in xwiki-officeimporter 2.2M1). > > Why make it compatible with 2.1.x, when it comes with the price of > reduced functionality? From what I see in the commit, you switched to > older APIs that are deprecated in 2.2, which means that a new module > will be released with deprecated code already, and at some later time it > will be harder to migrate, once more code is written. > We had a problem with a client project which was using 2.1 XE. So I changed dependencies to 2.1-SNAPSHOT to make this preview feature work with it. Since this was on sandbox I didn't worry much. But yes, this module should be targeting 2.2-SNAPSHOT instead. - Asiri > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
