On Jan 3, 2010, at 2:42 PM, Sergiu Dumitriu wrote: > Hi devs, > > Caty suggested a while ago to allow the users to set custom logos in > the > color theme. At first I thought this was not OK, since normally the > logo > should be the same regardless of the site colors, but now I realize > it's > a pretty good idea, because it ensures more flexibility, and, more > importantly, it allows to workaround transparency issues that appear > in > some browsers (yes, I'm talking about IE6) by setting logos with the > same background color as the header. > > The necessary changes would be: > - in "ColorThemes.ColorThemeClass" add a property called 'logo' whose > values are names of files attaches to the ColorTheme document > - in "global.vm", when searching for the wiki logo, start by looking > in > the current ColorTheme, and, if not found, continue as before. > > WDYT?
I'd agree but only if we remove the new notion of Color Theme and instead replace it with a notion of Skin Theme (which is more generic and better IMO since anything that can be customized should be in a theme, it's not just colors). We should also take the occasion to list other stuff that should be customizable in a Skin Theme, if any (even if we only implement them in the future). If we don't find anything else other than the logo maybe we could keep the ColorTheme name (even though it's wrong). If we find other areas we should probably find a migration path from ColorTheme to SkinTheme. Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
