Hi Marius, On Thu, Feb 25, 2010 at 9:59 AM, Marius Dumitru Florea <[email protected]> wrote: > Hi Anamaria, > > Anamaria Stoica wrote: >> Hi devs, >> >> I'm proposing we add the following method: > >> DocumentReference getEntityReference(); > > Why not getDocumentReference()? considering the returned type. >
Good observation, thanks! I put the return type as DocumentReference because this is what it got in the constructor of DefaultWikiMacro, but as DocumentReference extends EntityReference, we could make the new method return an EntityReference, thus have: EntityReference getEntityReference(); Question is now, does it make sense to have any Entity Reference as return type, or it must to be a document type? Thanks, Anamaria > +1 otherwise. > > Thanks, > Marius > >> >> to org.xwiki.rendering.macro.wikibridge.WikiMacro. >> >> This way we'll have a simple way to retrieve the wiki Document having >> the corresponding >> XWiki.WikiMacroClass xObject attached. >> >> Thanks, >> Anamaria >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
