On 2/28/10 6:06 PM, Vincent Massol wrote:
>
> On Feb 28, 2010, at 5:46 PM, Jerome Velociter wrote:
>
>> On 2/28/10 5:32 PM, vmassol (SVN) wrote:
>>> Author: vmassol
>>> Date: 2010-02-28 17:32:49 +0100 (Sun, 28 Feb 2010)
>>> New Revision: 27370
>>>
>>> Added:
>>>
>>> contrib/sandbox/webdriver-ui-tests/src/test/it/org/xwiki/it/ui/AbstractAdminAuthenticatedTest.java
>>> Removed:
>>>
>>> contrib/sandbox/webdriver-ui-tests/src/test/it/org/xwiki/it/ui/AbstractAdminAuthenticatedTest.java
>>> Modified:
>>>
>>> contrib/sandbox/webdriver-ui-tests/src/test/it/org/xwiki/it/ui/AbstractTest.java
>>>
>>> contrib/sandbox/webdriver-ui-tests/src/test/it/org/xwiki/it/ui/ImportTest.java
>>>
>>> contrib/sandbox/webdriver-ui-tests/src/test/it/org/xwiki/it/ui/LoginTest.java
>>>
>>> contrib/sandbox/webdriver-ui-tests/src/test/it/org/xwiki/it/ui/elements/AdministrationPage.java
>>>
>>> contrib/sandbox/webdriver-ui-tests/src/test/it/org/xwiki/it/ui/elements/BasePage.java
>>>
>>> contrib/sandbox/webdriver-ui-tests/src/test/it/org/xwiki/it/ui/elements/HistoryPane.java
>>>
>>> contrib/sandbox/webdriver-ui-tests/src/test/it/org/xwiki/it/ui/elements/HomePage.java
>>>
>>> contrib/sandbox/webdriver-ui-tests/src/test/it/org/xwiki/it/ui/elements/ImportPage.java
>>>
>>> contrib/sandbox/webdriver-ui-tests/src/test/it/org/xwiki/it/ui/elements/LoginPage.java
>>>
>>> contrib/sandbox/webdriver-ui-tests/src/test/it/org/xwiki/it/ui/elements/RegisterPage.java
>>> Log:
>>> Testing Selenium 2.0 (merge with WebDriver).
>>> * Make sure the package is deleted before the test if it's there
>>> * Added license headers
>>> * Minor refactorings
>>>
>>>
>>> - public void selectOptionReplaceHistory()
>>> + public void toggleReplaceHistoryOption()
>>> {
>>> getDriver().findElement(By.xpath("//inp...@name='historyStrategy'
>>> and @value='replace']")).click();
>>> }
>>
>> I don't think toggle is the right word here. Toggle usually refers to a
>> 2-states switch
>>
>> Mabye "selectReplaceHistoryOption" would better fit.
>
> The reason I've used toggle is because you had added a method called
> unselectOptionReplaceHistory() and its implementation was the same as
> selectOptionHistory.
Actually no, the (unused yet) method you deleted was
selectOptionResetHistory (that clicked the "reset" option). I wrote it
preemptively as I want to add a test for this "reset" option as well.
>
> Are you sure it's not a toggle, i.e if I click twice on it, it's not in the
> same state as initially?
No, it's a 3-state option with 3 radio buttons. If you click twice a
button it's remains in the selected state.
Jerome.
>
> Thanks
> -Vincent
>
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
