On Mon, Mar 1, 2010 at 17:46, Vincent Massol <[email protected]> wrote:
>
> On Mar 1, 2010, at 5:07 PM, tmortagne (SVN) wrote:
>
>> Author: tmortagne
>> Date: 2010-03-01 17:07:27 +0100 (Mon, 01 Mar 2010)
>> New Revision: 27393
>>
>> Modified:
>>   
>> platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/AdminGroupsSheet.xml
>>   
>> platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/AdminUsersSheet.xml
>> Log:
>> XAADMINISTRATION-116: Use the new get action for rights/users/groups UIs
>>
>> Modified: 
>> platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/AdminGroupsSheet.xml
>> ===================================================================
>> --- 
>> platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/AdminGroupsSheet.xml
>>     2010-03-01 16:05:43 UTC (rev 27392)
>> +++ 
>> platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/AdminGroupsSheet.xml
>>     2010-03-01 16:07:27 UTC (rev 27393)
>> @@ -1,10 +1,10 @@
>> -<?xml version="1.0" encoding="ISO-8859-1"?>
>> +<?xml version="1.0" encoding="UTF-8"?>
>>
>> <xwikidoc>
>> <web>XWiki</web>
>> <name>AdminGroupsSheet</name>
>> <language></language>
>> -<defaultLanguage></defaultLanguage>
>> +<defaultLanguage>en</defaultLanguage>
>
> hmm this doesn't look right to force the default language does it?

Well IMO it should not even exist at document level, it does not
really make sense. Now all documents i can see in svn have this set.

In fact its worst than that since i found some with
<defaultLanguage>fr</defaultLanguage> like
http://svn.xwiki.org/svnroot/xwiki/enterprise/trunk/wiki/src/main/resources/XWiki/DeletedAttachments.xml

>
>> <translation>0</translation>
>> <parent>XWiki.AdminSheet</parent>
>> <creator>XWiki.Admin</creator>
>> @@ -12,9 +12,9 @@
>> <customClass></customClass>
>> <contentAuthor>XWiki.Admin</contentAuthor>
>> <creationDate>1211800831000</creationDate>
>> -<date>1240956272000</date>
>> -<contentUpdateDate>1240956272000</contentUpdateDate>
>> -<version>1.1</version>
>> +<date>1267456765000</date>
>> +<contentUpdateDate>1267456765000</contentUpdateDate>
>> +<version>2.1</version>
>
> Version should start at 1.1.
>
>> <title>AdminGroupsSheet</title>
>> <template></template>
>> <defaultTemplate></defaultTemplate>
>> @@ -23,6 +23,40 @@
>> <minorEdit>false</minorEdit>
>> <syntaxId>xwiki/1.0</syntaxId>
>> <hidden>false</hidden>
>> +<object>
>> +<class>
>> +<name>XWiki.TagClass</name>
>
> You should not add the TagClass.
>
> Thanks
> -Vincent
>
>> +<customClass></customClass>
>> +<customMapping></customMapping>
>> +<defaultViewSheet></defaultViewSheet>
>> +<defaultEditSheet></defaultEditSheet>
>> +<defaultWeb></defaultWeb>
>> +<nameField></nameField>
>> +<validationScript></validationScript>
>> +<tags>
>> +<cache>0</cache>
>> +<displayType>checkbox</displayType>
>> +<multiSelect>1</multiSelect>
>> +<name>tags</name>
>> +<number>1</number>
>> +<prettyName>Tags</prettyName>
>> +<relationalStorage>1</relationalStorage>
>> +<separator> </separator>
>> +<separators> ,|</separators>
>> +<size>30</size>
>> +<unmodifiable>0</unmodifiable>
>> +<values></values>
>> +<classType>com.xpn.xwiki.objects.classes.StaticListClass</classType>
>> +</tags>
>> +</class>
>> +<name>XWiki.AdminGroupsSheet</name>
>> +<number>0</number>
>> +<className>XWiki.TagClass</className>
>> +<guid>3eff5967-b075-4744-8de7-9346e3a889bf</guid>
>> +<property>
>> +<tags/>
>> +</property>
>> +</object>
>> <content>### Globally administrate the groups in a wiki.
>> #set($formname = "update")
>> #set($saveaction = "save")
>> @@ -45,7 +79,7 @@
>> ##
>> ## url to get the groups for displaying them in the ajax-based table
>> ##
>> -#set($url = "?xpage=getgroups")
>> +#set($url = $doc.getURL('get', 'xpage=getgroups'))
>> #if($context.database != "xwiki")
>>   #set($mainwk = false)
>> #else
>
> [snip]
>
> Thanks
> -Vincent
>>
>
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
>



-- 
Thomas Mortagne
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to