On 03/06/2010 02:53 AM, Caleb James DeLisle wrote:
> sdumitriu (SVN) wrote:
>> Author: sdumitriu
>> Date: 2010-03-06 02:23:19 +0100 (Sat, 06 Mar 2010)
>> New Revision: 27501
>>
>> Modified:
>>     
>> platform/web/trunk/standard/src/main/webapp/templates/informationinline.vm
>> Log:
>> XWIKI-4980: Backlink information is not sorted by space
>> Fixed.
>>
>> Modified: 
>> platform/web/trunk/standard/src/main/webapp/templates/informationinline.vm
>> ===================================================================
>> --- 
>> platform/web/trunk/standard/src/main/webapp/templates/informationinline.vm   
>>     2010-03-06 01:20:42 UTC (rev 27500)
>> +++ 
>> platform/web/trunk/standard/src/main/webapp/templates/informationinline.vm   
>>     2010-03-06 01:23:19 UTC (rev 27501)
>> @@ -40,7 +40,7 @@
>>             </dd>
>>         #end
>>         #end
>> -      #set($blinks = $doc.getBacklinks())
>
> Should getBackLinks use an "order by" clause at the database level?
> I don't think any order is guaranteed at the moment in which case it would 
> not be breaking API.
> Also getChildren could be changed at the same time since documents can have 
> children in other spaces.

Yes, I thought about this too, and I agree. But I chose the quickest and 
safest approach for the moment.

>> +      #set($blinks = $sorttool.sort($doc.getBacklinks()))
>>         #if($blinks.size()>0)
>>           <dt>$msg.get('core.viewers.information.backlinks')</dt>
>>           <dd>

-- 
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to