Hi Vincent,


> > If you are referring to this specific new feature or integration tests,
> No
> > there are none.
>
> Yes that's my question, why are there none? We shouldn't apply or accept
> patches that don't have tests to prove they work (unless when it's about
> some old code modifications and writing tests is just too hard).
>
> Could you add some tests to prove this new feature?
>

ParameterDescriptor interface have the method getDefaultValue() which
returns an object. WikiMacroParameterDescriptor class used to return null
and what anamaria has done is to make it return a user specified (via a new
constructor) default value object. I do not think this needs any test.

- Asiri
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to