On Mar 10, 2010, at 1:39 PM, Thomas Mortagne wrote:

> On Wed, Mar 10, 2010 at 13:35, Vincent Massol <[email protected]> wrote:
>> 
>> On Mar 10, 2010, at 1:29 PM, Sergiu Dumitriu wrote:
>> 
>>> On 03/10/2010 08:58 AM, vmassol (SVN) wrote:
>>>> Author: vmassol
>>>> Date: 2010-03-10 08:58:56 +0100 (Wed, 10 Mar 2010)
>>>> New Revision: 27563
>>>> 
>>>> Modified:
>>>>    
>>>> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-velocity/src/main/java/org/xwiki/rendering/internal/macro/velocity/VelocityMacro.java
>>>> Log:
>>>> fixed invalid javadoc
>>>> 
>>>> Modified: 
>>>> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-velocity/src/main/java/org/xwiki/rendering/internal/macro/velocity/VelocityMacro.java
>>>> ===================================================================
>>>> --- 
>>>> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-velocity/src/main/java/org/xwiki/rendering/internal/macro/velocity/VelocityMacro.java
>>>>    2010-03-10 06:43:01 UTC (rev 27562)
>>>> +++ 
>>>> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-velocity/src/main/java/org/xwiki/rendering/internal/macro/velocity/VelocityMacro.java
>>>>    2010-03-10 07:58:56 UTC (rev 27563)
>>>> @@ -87,7 +87,7 @@
>>>>      /**
>>>>       * {...@inheritdoc}
>>>>       *
>>> 
>>> Why is this invalid?
>> 
>> because ScriptMacroParameters is not known to the class so you'd need the 
>> full package name.
> 
> why not put the full package name then ?

hey you guys are predictable :)

I didn't use the FQN because it was going beyond 120 chars and using no param 
is a valid way of referencing a method (you only need to specify params when 
there are more than 1 signature for a method).

Thanks
-Vincent

> 
>> 
>> -Vincent
>> 
>>> 
>>>> -     * @see AbstractScriptMacro#evaluate(ScriptMacroParameters, String, 
>>>> MacroTransformationContext)
>>>> +     * @see AbstractScriptMacro#evaluate
>>>>       */
>>>>      @Override
>>>>      protected String evaluate(VelocityMacroParameters parameters, String 
>>>> content, MacroTransformationContext context)
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to