Hi Anamaria,
Yes, that's how it should behave. I created a small patch to take care > of that too, see: > > > http://jira.xwiki.org/jira/browse/XWIKI-4944?focusedCommentId=49570&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_49570 > ( XWIKI-4944_patch_return_default_values.txt ) > You need a test case to make sure that this works. There are two options: 1. Check DefaultWikiMacroTest, you need to add a test which registers a wiki macro containing a script like {{velocity}}$xcontext.macro.params.param1{{/velocity}} and verify the output of the wiki macro. 2. Use mocks to avoid actual macro execution and check whether parameters are set correctly. I would prefer (1) because it sounds easy ;) Thanks. - Asiri > > Thanks, > Anamaria > > >> > >> Thanks. > >> > >> - Asiri > >> > >> > >>> > >>> Thanks, > >>> Marius > >>> > >>> > > >>> > Thanks, > >>> > Anamaria > >>> > > >>> > > >>> > On Fri, Feb 26, 2010 at 3:50 PM, Thomas Mortagne > >>> > <[email protected]> wrote: > >>> >> +1 for the general: as soon as it's part of Macro and parameter > >>> >> descriptor it should be supported by wiki macros at some point > anyway > >>> >> > >>> >> On Fri, Feb 26, 2010 at 11:43, Anamaria Stoica < > [email protected]> > >>> wrote: > >>> >>> Hi, > >>> >>> > >>> >>> I would like to add support for Default Values for XWiki Wiki > Macros. > >>> >>> It's not very difficult, as the XWiki Java Macros already have it. > >>> >>> > >>> >>> The required changes would be: > >>> >>> - add default value property to XWiki.WikiMacroParameterClass > >>> >>> - update DefaultWikiMacroFactory#buildMacro() to parse the new > >>> parameter > >>> >>> - update WikiMacroParameterDescriptor with a new property for > default > >>> >>> value parameter, a new constructor and also > >>> >>> update the getDefaultValue method > >>> >>> > >>> >>> Thanks, > >>> >>> Anamaria > >>> >>> _______________________________________________ > >>> >>> devs mailing list > >>> >>> [email protected] > >>> >>> http://lists.xwiki.org/mailman/listinfo/devs > >>> >>> > >>> >> > >>> >> > >>> >> -- > >>> >> Thomas Mortagne > >>> >> _______________________________________________ > >>> >> devs mailing list > >>> >> [email protected] > >>> >> http://lists.xwiki.org/mailman/listinfo/devs > >>> >> > >>> > _______________________________________________ > >>> > devs mailing list > >>> > [email protected] > >>> > http://lists.xwiki.org/mailman/listinfo/devs > >>> _______________________________________________ > >>> devs mailing list > >>> [email protected] > >>> http://lists.xwiki.org/mailman/listinfo/devs > >>> > >> _______________________________________________ > >> devs mailing list > >> [email protected] > >> http://lists.xwiki.org/mailman/listinfo/devs > >> > > > > > > > > -- > > Thomas Mortagne > > _______________________________________________ > > devs mailing list > > [email protected] > > http://lists.xwiki.org/mailman/listinfo/devs > > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
