Hi,
> > > > 3. Each generated office-preview is cached. When a cache entry is > disposed, > > all the temporary files associated with that preview is deleted > > (DisposableCacheValue). However, I noticed that > > DisposableCacheValue::dispose() is not invoked when XE shuts down. We > could > > fix this by adding an event listener to listen for XE shutdown events and > > calling DisposableCacheValue::dispose() manually. > > Actually the issue is that you don't do it the right way IMO: in java > you can "tag" a file as real temporary files, i.e. that is supposed to > be deleted when java stops. > > See File#deleteOnExit > Hmmm, that didn't come to my mind. Thanks :) > > > > > 4. A requested feature (by ludovic) is to cache the whole office-preview > > (i.e. XDOM + tempfiles) on the disk, this way previews will even survive > XE > > restarts. This is something we need to agree on. > > I'm not sure what this "feature" brings. Is it that long to generate > the temporary file and XDOM the first time it's used before caching it > ? > Yes. Invoking openoffice, creating XDOM + temporary files can take some time specially if the office attachment is quite large. However, we can also consider using some javascript icing to make the user wait (first time only) instead. - Asiri _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
