On Wed, May 5, 2010 at 14:35, Sergiu Dumitriu <[email protected]> wrote:
> On 05/05/2010 02:28 PM, tmortagne (SVN) wrote:
>> Author: tmortagne
>> Date: 2010-05-05 14:28:17 +0200 (Wed, 05 May 2010)
>> New Revision: 28726
>>
>> Modified:
>>
>> platform/web/branches/xwiki-web-2.3/standard/src/main/webapp/templates/commentsinline.vm
>>
>> platform/web/branches/xwiki-web-2.3/standard/src/main/webapp/templates/informationinline.vm
>> Log:
>> [misc] Fix XHTML validity
>>
>> Modified:
>> platform/web/branches/xwiki-web-2.3/standard/src/main/webapp/templates/commentsinline.vm
>> ===================================================================
>> ---
>> platform/web/branches/xwiki-web-2.3/standard/src/main/webapp/templates/commentsinline.vm
>> 2010-05-05 12:27:21 UTC (rev 28725)
>> +++
>> platform/web/branches/xwiki-web-2.3/standard/src/main/webapp/templates/commentsinline.vm
>> 2010-05-05 12:28:17 UTC (rev 28726)
>> @@ -90,7 +90,7 @@
>> #foreach($name in $request.getParameterNames())
>> #set($queryString =
>> "$!queryString&$name=$escapetool.url($request.get($name))")
>> #end
>> -
>> $response.sendRedirect("$doc.getURL('view')?captchaAnswerWrong=1&$queryString");
>> + $response.sendRedirect("$doc.getURL('view',
>> "captchaAnswerWrong=1&$queryString")");
>
> Are you sure this works? Looks like nested quotes which makes Velocity a
Indeed this is wrong i apply the same thing that if it was a <a href
instead of sendRedirect call. I'm fixing it.
> bit unhappy... Also the & is still unescaped.
Actually i tough getURL was doing the job when since when testing in a
page i got proper escaping but it's probably escaped by XHTML renderer
now that i'm thinking more about it.
>
> $response.sendRedirect($doc.getURL('view',
> "captchaAnswerWrong=1&$queryString"));
>
>> #end
>> $response.setContentLength(0)
>> #stop
>
>
> --
> Sergiu Dumitriu
> http://purl.org/net/sergiu/
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
>
--
Thomas Mortagne
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
