+1

Denis

On Wed, May 5, 2010 at 19:19, Sergiu Dumitriu <[email protected]> wrote:

> On 05/05/2010 05:08 PM, Jerome Velociter wrote:
> > Hi devs,
> >
> > Due to special circumstances (hitting XWIKI-5166 while upgrade XWiki.org
> to 2.3), we've face the<body>  database className conflict again, on
> code.xwiki.org.
> >
> > What happens is that the "code" DOM class name is apposed to the body
> element (see htmlheader.vm), and this interferes with styles defined for the
> {{code}} macro. Potentially there are other scenarios where class names can
> conflict with database names.
> >
> > I propose we prefix the apposed class name with "wiki-" (that's what
> we've been doing on xwiki.org for some time now) in order to avoid this.
>
> +1
>
> > Though, we need to agree on this, since it can be a breaking change for
> those who relied on that "feature" to skin differently different wikis on a
> farm.
>
> --
> Sergiu Dumitriu
> http://purl.org/net/sergiu/
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
>



-- 
Denis Gervalle
SOFTEC sa - CEO
eGuilde sarl - CTO
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to