Hi Denis, It's pretty nice.
I've added an annotation on the patch http://incubator.myxwiki.org/xwiki/bin/view/Improvements/LivetablePageSizer#Annotations The annotation dropped the end of my selection, it actually concerns the following lines : + #if($!hasPageSize) + document.observe("xwiki:livetable:${divid}:loadingEntries", function() { $('${divid}-pagesize').addClassName("hidden"); } ); + document.observe("xwiki:livetable:${divid}:loadingComplete", function() { $('${divid}-pagesize').removeClassName("hidden"); } ); + #end Jerome. ----- Original Message ----- From: "Guillaume Lerouge" <[email protected]> To: "XWiki Developers" <[email protected]> Sent: Thursday, May 6, 2010 3:10:01 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: [xwiki-devs] [Proposal] Support choosing pagination size in livetable UI Hi, On Thu, May 6, 2010 at 15:05, Denis Gervalle <[email protected]> wrote: > On Thu, May 6, 2010 at 14:55, Guillaume Lerouge <[email protected]> > wrote: > > > Hi, > > > > On Thu, May 6, 2010 at 14:33, Denis Gervalle <[email protected]> wrote: > > > > > Hi devs, > > > > > > Currently the number of rows displayed in a livetable is fixed at > > creation > > > time. > > > I proposed to add UI controls (currently select) that allows to change > > the > > > pagination size freely by the end user. > > > > > > This patch is be both a change in livetable.js to support these > controls > > > (one or more), and a change in the livetable macro to allow displaying > > > them. > > > I have already a patch and some screenshots as well as bare > > documentation, > > > you can review them all at > > > > > > http://incubator.myxwiki.org/xwiki/bin/view/Improvements/LivetablePageSizer > > > > > > I am currently testing different browsers to ensure there is no > > regression. > > > > > > WDYT ? > > > > > > > Sounds very nice to me, I was asked about it in the past so I'm +1. > > > > Only question -> is the preference remembered for the user? I guess not > and > > that the default still is the number chose by the livetable creator, but > > thought I'd ask. > > > > Well this is mainly a new functionality on the livetable, no change in XE > in > my patch currently. My feeling is that keeping the information for the user > should not be done by the livetable itself (JS), but by the caller (the > macro, why not). It would not be so difficult to do with cookies, it would > be a little bit more work to store the information in the user profile. > Anyway, this is a second step. > > By the way, I have not proposed to change the current pages of XE, but it > could be a nice idea. Do not hesitate to propose page you want me to > improve. The other way, we may also set this new feature as a default, so > it > will apear on all existing livetables using the macro, and allow disabling > it. WDYT ? > Yes, I'd make this available by default to all livetables, with a configuration parameter allowing to disable it on a case-by-case basis. Guillaume > Denis > > -- > Denis Gervalle > SOFTEC sa - CEO > eGuilde sarl - CTO > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Guillaume Lerouge Product Manager - XWiki SAS Skype: wikibc Twitter: glerouge http://guillaumelerouge.com/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
