On May 13, 2010, at 11:46 AM, Ciprian Amaritei wrote: > Hi, > New version improved: > http://incubator.myxwiki.org/xwiki/bin/view/Ciprian/Search%20icon > > - neutral colors used > - old text replaced with "xwiki" > - search button inline with the edit field
Looks great to me. -Vincent > > On Wed, May 12, 2010 at 1:57 PM, Thomas Mortagne > <[email protected]>wrote: > >> On Wed, May 12, 2010 at 12:11, Vincent Massol <[email protected]> wrote: >> >>> >>> On May 12, 2010, at 11:11 AM, Ciprian Amaritei wrote: >>> >>>> Hi, >>>> >>>> I made a search admin icon. You can see it on: >>>> >>>> http://incubator.myxwiki.org/xwiki/bin/view/Ciprian/Search%20icon >>> >> >> +1 for version2 >> >> >>>> >>>> Please take a look and give some suggestions. >>> >>> Looks good but 2 questions/remarks: >> >> - why does it say xwiki.cfg? IMO saying "xwiki" should be enough, or maybe >>> "xwiki search" >>> >> >> +1 >> >> - re the color we should stay neutral so that it fits well with all themes >>> and with the rest of the admin icons >>> >>> Thanks >>> -Vincent >>> >>>> Thanks, >>>> Ciprian. >>>> >>>> On Thu, May 6, 2010 at 1:27 PM, Thomas Mortagne >>>> <[email protected]>wrote: >>>> >>>>> Hi devs, >>>>> >>>>> I committed the new search admin UI and fixed some issuse, should work >>> well >>>>> now. >>>>> >>>>> Some notes: >>>>> * the actual configuration is put in a document automatically created >>>>> if it does not exist so that you can upgrade the whole app without >>>>> having to worry about what you will overwrite >>>>> * it's using Configurable system but just to be "injected" as admin >>>>> app, would be nice to be able to have some reusable code when you need >>>>> custom UI but still we some standard configuration style in the middle >>>>> of it >>>>> * there is a new central search page (Main.Search) which include the >>>>> proper engine search page depending of the configuration >>>>> >>>>> Missing things are: >>>>> * an nice icon: would be cool to have someone else than me on that >>>>> * rename "web" into "database", i just moved the page yet but "web" is >>>>> not very nice and i need to change it. I'm just a bit worried about >>>>> backward compatibility, i think i will create a DatabaseSearch page >>>>> and redirect WebSearch to Search probably to make old apps use the >>>>> right default search engine instead of the old hardcoded websearch >>>>> default page >>>>> * make number of indexing element refresh automatically using ajax: >>>>> i'm working on something else right and it's not urgent but i will >>>>> take care of it (I'm not begging for it if someone want to take it ;)) >>>>> * write documentation for it in xwiki.org (especially about how to >> use >>>>> indexing UI), about that do we have some clean way to put >>>>> documentation tooltips or something nice to explain to the use what he >>>>> can put in the fields and how it's working ? >>>>> >>>>> Would be cool that some people review it (pretty sure there is typos I >>>>> did not seen, there is always...). >>>>> >>>>> Thanks, >>>>> -- >>>>> Thomas Mortagne >>>>> _________________ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

