On Jun 11, 2010, at 12:17 PM, Thomas Mortagne wrote: > On Fri, Jun 11, 2010 at 12:13, Thomas Mortagne > <[email protected]> wrote: >> On Fri, Jun 11, 2010 at 11:29, Vincent Massol <[email protected]> wrote: >>> >>> On Jun 11, 2010, at 11:13 AM, Thomas Mortagne wrote: >>> >>>> On Fri, Jun 11, 2010 at 09:03, Vincent Massol <[email protected]> wrote: >>>>> Hi devs, >>>>> >>>>> I'm wondering why we haven't moved to using XQL instead of HQL. >>>>> >>>>> Any reason? >>>>> >>>>> If not, I'd like to suggest we start using it everywhere we currently use >>>>> HQL since XWQL since is much nicer. Also since we don't use it our users >>>>> don't use it. >>>>> >>>>> Additionally I'd like to propose that we move to a ScriptService to >>>>> access the query manager. >>>>> >>>>> From Velocity you'd write the following to get a Query: >>>>> $services.query.xwql("....") >>>>> >>>>> Note that the ScriptService implementation would replace the >>>>> SecureQueryManager implementation. >>>>> >>>>> We would also deprecate XWiki.getQueryManager. >>>>> >>>>> WDYT? >>>> >>>> I think the major issue is that nobody knows it very well and without >>>> Artem to push on it and help we just forgot about it. >>>> >>>> Also I think Artem was waiting JCR2 that was not release when he >>>> started working on it to finish XQL implementation that was too >>>> limited by JCR1. >>> >>> XWQL is not tied to JCR (the execution engine is Hibernate right now). It's >>> tied to JPQA but only at the grammar level (we have our grammer and our >>> parser). >> >> I talked about XQL not the query manager. I tough JPQL was part of JCR. >> >>> >>> Why do you think it's not finished? from what I've seen it looks finished >>> and it worked well when I used it. >> >> I said "i think". >> >>> >>> I only saw a potential grammar issue that you are forces to use "as" for a >>> query to be valid. For example: >>> "from doc.object(XWiki.XWikiUsers) as user" >>> >>> (using "from doc.object(XWiki.XWikiUsers)" will not work) > > Anyway my main point is that if we start to use it a lot it makes it > critical and we need somebody to take care of that since we will find > bugs for sure.
Yes, I suggest we start using it right now (ie 2.4M2) for a few queries. We'll see how well it works and can always rollback if needed. -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
