On Wed, Jun 23, 2010 at 08:26, Vincent Massol <[email protected]> wrote: > > On Jun 23, 2010, at 8:17 AM, Thomas Mortagne wrote: > >> On Wed, Jun 23, 2010 at 08:14, Vincent Massol <[email protected]> wrote: >>> >>> On Jun 22, 2010, at 11:17 PM, Marius Dumitru Florea wrote: >>> >>>> Hi Vincent, >>>> >>>> On 06/22/2010 03:37 PM, Vincent Massol wrote: >>>>> >>>>> On Jun 22, 2010, at 2:33 PM, Vincent Massol wrote: >>>>> >>>>>> >>>>>> On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote: >>>>>> >>>>>>> Hi devs, >>>>>>> >>>>>>> I'm proposing to have org.xwiki.it.ui.elements.<application name> >>>>>>> where<application name> is the name of the application containing the >>>>>>> page. >>>>>>> >>>>>>> WDYT? >>>>>> >>>>>> We also need to separate the tests themselves so we need a larger >>>>>> proposal. I'm now proposing this: >>>>>> >>>>>> org.xwiki.ui.test.<application name>.elements.*<-- elements >>>>>> org.xwiki.ui.test.<application name>.*<-- tests >>>>> >>>>> We also need a place for generic stuff and for XE-specific pages >>>>> (althought they should disappear in the future): >>>>> >>>>> Generic stuff: >>>>> org.xwiki.ui.test.framework.elements.* >>>>> >>>>> XE: >>>>> org.xwiki.ui.test.xe.elements.* >>>>> org.xwiki.ui.test.xe.* >>>>> >>>>> WDYT? >>>> >>>> I'm a bit puzzled. The proposal you made above is clear, but in this >>>> thread you also say: >>>> >>>> "Right now I have put generic tests that don't belong to an app in the >>>> org.xwiki.it.ui package (next to AllTest)." >>>> >>>> and >>>> >>>> "They are in org.xwiki.ui.administration (I haven't put tests in a >>>> specific "test" package)." >>> >>> - Tests for the admin app are in admin (org.xwiki.it.ui.administration) >>> - Generic tests (no app) are in org.xwiki.it.ui >> >> So why is your proposal org.xwiki.ui.test.<application name> and not >> org.xwiki.ui.<application name> ? > > Because it's an error of the proposal :)
Ok so that's why me and Marius did not understood what happen then. > > I didn't plan to change the current package prefix used which is: > org.xwiki.it.ui. I was only talking about the suffix starting at that level. > > Please check what I've done in the following dir and let me know if that's ok: > http://svn.xwiki.org/svnroot/xwiki/enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/ > > Thanks > -Vincent > >>> See >>> http://svn.xwiki.org/svnroot/xwiki/enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/ >>> >>> Thanks >>> -Vincent >>> >>>> >>>> So is it: >>>> >>>> org.xwiki.ui.test.administration.* >>>> or >>>> org.xwiki.ui.administration.* >>>> or >>>> org.xwiki.it.ui.test.administration.* >>>> or >>>> org.xwiki.it.ui.administration.* ? >>>> >>>> Thanks, >>>> Marius > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
