On Jun 28, 2010, at 5:02 PM, jvdrean (SVN) wrote:

> Author: jvdrean
> Date: 2010-06-28 17:02:21 +0200 (Mon, 28 Jun 2010)
> New Revision: 29794
> 
> Modified:
>   
> enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/administration/elements/AdminTemplatesPage.java
>   
> platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/AdminTemplatesSheet.xml
> Log:
> [misc] Little refactoring
> 
> 
> Modified: 
> enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/administration/elements/AdminTemplatesPage.java
> ===================================================================
> --- 
> enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/administration/elements/AdminTemplatesPage.java
>    2010-06-28 14:48:38 UTC (rev 29793)
> +++ 
> enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/administration/elements/AdminTemplatesPage.java
>    2010-06-28 15:02:21 UTC (rev 29794)
> @@ -36,7 +36,7 @@
>     @FindBy(id = "page")
>     private WebElement pageInput;
> 
> -    @FindBy(xpath = "//form/div/inp...@type='submit']")
> +    @FindBy(xpath = "//inp...@id='createTemplateProvider']")

Almost :)

@FindBy(id = 'createTemplateProvider') (since ids are unique)

Do we have a naming convention for ids?

Thanks
-Vincent

>     private WebElement createButton;
> 
>     public AdminTemplatesPage()
> 
> Modified: 
> platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/AdminTemplatesSheet.xml
> ===================================================================
> --- 
> platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/AdminTemplatesSheet.xml
>  2010-06-28 14:48:38 UTC (rev 29793)
> +++ 
> platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/AdminTemplatesSheet.xml
>  2010-06-28 15:02:21 UTC (rev 29794)
> @@ -34,7 +34,7 @@
>       <input type="text" id="space" name="space" value="XWiki" 
> size="8"/>
>       <label 
> for="page">$msg.get('admin.templates.createprovider.page')</label>
>       <input type="text" id="page" name="page" 
> value="$msg.get('admin.templates.createprovider.defaultdocname')" 
> class="withTip"'/>    
> -      <input type="submit" 
> value="$msg.get('admin.templates.createprovider.create')" class="button"/>
> +      <input id="createTemplateProvider" type="submit" 
> value="$msg.get('admin.templates.createprovider.create')" class="button"/>
>     </div>  
>   </form>
> {{/html}}
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to