On 07/07/2010 09:35 PM, Sergiu Dumitriu wrote: > On 07/06/2010 10:15 PM, Sergiu Dumitriu wrote: >> On 07/04/2010 09:13 PM, Sergiu Dumitriu wrote: >>> On 07/03/2010 11:05 AM, Vincent Massol wrote: >>>> Hi, >>>> >>>> Since we're way off for our release dates of XE 2.4 (we'll need to do >>>> a retrospective and understand what happened so that we improve >>>> ourselves for the next time), I'd like to propose the following new >>>> dates: >>>> >>>> Original Dates: >>>> - XE 2.4RC1: 28 June 2010 >>>> - XE 2.4 RC2 (if needed): 5 July 2010 >>>> - XE 2.4 Final: 12 July 2010 >>>> >>>> New proposed dates: >>>> - XE 2.4RC1: 7th of July >>>> - XE 2.4Final: 15th of July >>>> >>>> BTW just to be sure, from now on we should only fix bugs and be very >>>> careful about not introducing any risky things, in order to prevent >>>> forcing us to have a RC2 since we're short on time. >>>> >>>> WDYT? >>> >>> +1 on the idea, but -1 for a final release until we find out what's >>> killing myxwiki, and until we fix the unparsed velocity macros bug. >>> >> >> Found (and hopefully fixed) what's killing myxwiki: >> http://jira.xwiki.org/jira/browse/XWIKI-5332 >> >> Still no idea why macros are sometimes unparsed. >> >> There's another issue, after a restart wiki-wide wiki macros are not >> correctly registered, and each document must be re-saved to make it work. > > Fixed wiki macro registration: > http://jira.xwiki.org/jira/browse/XWIKI-5334 > > The unparsed macro issue is not critical, since it is hard to reproduce > manually (it occurs mostly during tests).
I think I know what the problem is. Since we're cleaning the macro cache when a page finished rendering, when two or more requests for the same page exist, the macro cache is cleared after the first one finished rendering, leaving all the others without the macro definitions. One quick way to fix this is to use counters and only clear a macro namespace when there are no more users of that namespace. > +1 for releasing 2.4-rc-1 > tomorrow, July 8th. -- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
