Thank you, it's great to be part of the team :) Alex
On 08/16/2010 04:58 PM, Caleb James DeLisle wrote: > Rsults: > 6 +1 > 0 +0 > 0 -1 > > Congratulations Alex, you are now a committer. > > I will add http://www.xwiki.org/xwiki/bin/view/XWiki/abusenius to the > XWikiCommittersGroup. > > Caleb > > > Sergiu Dumitriu wrote: >> On 08/11/2010 04:38 PM, Caleb James DeLisle wrote: >>> Hello, >>> >>> I have been working with Alex on security related code and have been >>> impressed with his abilities as well as >>> dedication to consistent improvement of the project and his own code. >>> >>> Alex has worked on some complex changes to difficult code such as: >>> >>> XWIKI-5275: Prevent nested script macros. >>> http://jira.xwiki.org/jira/browse/XWIKI-5275 >>> >>> As well as a large quantity of cross site script related patches such as: >>> >>> XWIKI-5161: Using XML symbols (<,>,&, ") inside the document >>> title/name/space breaks various parts of the UI and causes the PDF export >>> to throw exceptions >>> http://jira.xwiki.org/jira/browse/XWIKI-5161 >>> >>> A full list is here, most are not viewable by the public. >>> http://jira.xwiki.org/jira/secure/ViewProfile.jspa?name=nickless#selectedTab=com.atlassian.streams.streams-jira-plugin:user-profile-stream-panel >>> >>> Alex has developed an automated cross site script fuzzing test which can be >>> seen here: >>> http://svn.xwiki.org/svnroot/xwiki/contrib/sandbox/xwiki-enterprise-test-escaping/ >>> >>> He is also responsible for parts of xwiki-crypto including PKCS7 signing >>> and validation and X509 certificate handling. >>> see: >>> http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-crypto/src/main/java/org/xwiki/crypto/x509/XWikiX509Certificate.java >>> http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-crypto/src/main/java/org/xwiki/crypto/x509/internal/X509SignatureService.java >>> http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-crypto/src/main/java/org/xwiki/crypto/x509/internal/AbstractX509CertificateWrapper.java >>> >>> >>> As far as write access to the main repository, I think there is no question >>> that he will be a good committer. >>> It should be noted that I would be +1 for giving write access to anyone who >>> demonstrates a need. >>> >>> The remaining issue is the responsibility of being on the "steering >>> committee", having the power to -1 a vote. >>> Alex and I agree on a lot of issues where we hold the minority position so >>> my opinion should be taken with the salt it deserves. >>> That said, he has the courage to voice disagreement when he has it, >>> he takes an interest in decisions regarding the core rather than being >>> concentrated on the user interface, >>> and he has the ability to spot problems in design which will not become >>> obvious until later. >>> >>> I think Alex Busenius will be a great committer. >> >> +1. >> >> Just a reminder, as with any other committer, whenever you're not sure >> of something, posting patches and asking for review is a good option. >> > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
