+1 Thanks, Marius
On 08/20/2010 02:13 PM, Caleb James DeLisle wrote: > There are a number of public methods in XWikiHibernateStore which are either > nolonger used, > unused outside of XWikiHibernateStore, or used in only a few places in old > code. > To make maintainence easier I propose deprecating them to discourage outside > code from using them > so they can later be removed or made private. > > Here is a list: > > saveXWikiObject > used 1 place in c.x.x.XWiki#addUserToGroup which appears to be easily > fixed. > saveXWikiCollection > used 3 places in the stats plugin. > loadXWikiObject > used 1 place in the old query plugin. > loadXWikiCollection > used 3 places in the stats plugin. > deleteXWikiCollection > used 1 place in stats plugin. > deleteXWikiCollection > used 1 place in stats plugin. > deleteXWikiClass > used nowhere. > loadXWikiProperty > used nowhere (outside of XWikiHibernateStore). > saveXWikiClass > used nowhere (outside of XWikiHibernateStore). > loadXWikiClass > used nowhere (outside of XWikiHibernateStore). > saveXWikiClassProperty > used nowhere. > loadAttachmentList > used nowhere (outside of XWikiHibernateStore). > saveAttachmentList > used nowhere (outside of XWikiHibernateStore). > saveAttachment > used nowhere (outside of XWikiHibernateStore). > injectCustomMappingsInSessionFactory > used nowhere (outside of XWikiHibernateStore). > injectInSessionFactory > used nowhere (outside of XWikiHibernateStore). > isValidCustomMapping > used nowhere (outside of XWikiHibernateStore). > getBatcherStats > used nowhere. > resetBatcherStats > used nowhere. > > > WDYT? > > Caleb > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
