5 +1, no -1 Committed, thanks.
----- Original Message ----- From: "Alex Busenius" <[email protected]> To: [email protected] Sent: Friday, August 27, 2010 10:26:55 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: [xwiki-devs] [Proposal] Stop logging errors when a wiki macro cannot be registered due to insufficient privileges for the asked visibility +1 Alex On 08/27/2010 01:04 AM, Jerome Velociter wrote: > Hi friends, > > I'm proposing a patch (see http://jira.xwiki.org/jira/browse/XWIKI-5439) to > stop logging a full exception at error level when the wiki fails to register > a wiki macro due to insufficient privileges for the asked visibility. > > This is currently what happens, and it can trash your log, for example if you > initialize a farm with hundreds of wikis throwing couple of times such error > :) > > Thing is this is not a real error, in the sense "something went wrong" so it > should be logged at the debug level. > > The patch introduce a new exception : > org.xwiki.rendering.macro.wikibridge.InsufficientPrivilegesException, which > when caught by the wiki macro initializer is logged at debug level, by > opposition of the more generic > org.xwiki.rendering.macro.wikibridge.WikiMacroException that remains logged > at error level. > > I'm calling for a vote since the patch introduce a API signature change. > Though I tend to think it's internal enough not to go through deprecation > cycle. > > My +1 > > Jerome. > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
