On 10/20/2010 04:21 PM, Vincent Massol wrote: > > On Oct 20, 2010, at 4:05 PM, Anca Luca wrote: > >> Hi devs, >> >> I've been working on http://jira.xwiki.org/jira/browse/XE-721 and it's >> done on my local. This is the recent changes macro based on the current >> implementation (not the activity stream one), but the idea is that we'll >> rewrite it to display recent activity in the future. I will commit it >> for the moment, in the 2.6 trunk, as is, but I would like to discuss >> here the name of the macro and its parameters: >> >> Macro name: >> >> recentchanges, changes, activity, recentactivity > > +1 for "activity" to be in line with the upcoming recent activity feature > planned for 2.6. > > No need for "recent", "activity" is enough. It's about the activity of the > wiki. > >> Parameters: >> >> * rss link should be shown at the bottom of the changes table (boolean): >> showRss, rss > > +1 rss (default true) > >> * minor changes are shown or not (boolean, default false): showMinor, minor > > +1 minor > >> * shows "see modifications" link next to entries (boolean, default >> true): showDiff, showDifferences, diff, differences > > I don't like too much diff* > > What about "actions"? It's more than just the difference link, there could be > other actions, as in the {{spaces/}} macro for example.
I'm fine with actions, it expresses better the fact that it's about an item option and not about something which is displayed or not. > >> * number of changes to show (number, 0 means "all", defaults to 30): >> changesNb, changesCount, number, count, limit > > +1 count > >> * tags of documents to show chages for (comma separated list): tag, tags > > +1 tags > >> * spaces of documents to show changes for (comma separated list): space, >> spaces > > +1 spaces > >> * authors of documents to show changes for (comma separated list): >> author, authors > > +1 authors > >> Note that the types cannot be enforced since it's a wiki macro, I put >> them there just for orientation. >> >> I'd go for >> activity rss minor diff count tags spaces authors . > > Thanks > -Vincent > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
